Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs: 0.8.2 -> 0.8.3 #78415

Merged
merged 1 commit into from Jan 25, 2020
Merged

zfs: 0.8.2 -> 0.8.3 #78415

merged 1 commit into from Jan 25, 2020

Conversation

sjau
Copy link

@sjau sjau commented Jan 24, 2020

Motivation for this change

Updating zfs to latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@balsoft
Copy link
Member

balsoft commented Jan 24, 2020

Possible duplicate of #77652

@wizeman wizeman mentioned this pull request Jan 24, 2020
Closed
10 tasks
@NeQuissimus
Copy link
Member

NeQuissimus commented Jan 24, 2020 •
edited

I am just building this to verify, LGTM otherwise.

Edit: I closed my PR, it was virtually identical but you have a nicer way of dealing with the systemd unit

@sjau
Copy link
Author

sjau commented Jan 24, 2020

@NeQuissimus
Not sure about it being nicer. I just used single quotes on the search part so expansion won't interfere. There wasn't a need to close yours though (tbh, I just saw that 0.8.3 was released and has nvme fixes, so I just wanted to include it. I didn't think to check if someone else already made a PR).

@NeQuissimus
Copy link
Member

This is good to go, my laptop is happy with it :) (Kernel 5.4.13-hardened)

@markuskowa
Copy link
Member

@GrahamcOfBorg test zfs
@GrahamcOfBorg build nixosTests.installer.zfsroot

markuskowa
markuskowa approved these changes Jan 25, 2020
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes; the zfs installer test passes locally

@NeQuissimus NeQuissimus merged commit d004a3c into NixOS:master Jan 25, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 28, 2020
@NeQuissimus @dtzWill
Merge pull request NixOS#78415 from sjau/zfs-0.8.3
dbeb932 
zfs: 0.8.2 -> 0.8.3
(cherry picked from commit d004a3c)
@sjau sjau deleted the zfs-0.8.3 branch April 11, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sjau @balsoft @NeQuissimus @markuskowa