Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotify-tui: 0.11.0 -> 0.12.0 #78355

Merged
merged 1 commit into from Jan 23, 2020
Merged

spotify-tui: 0.11.0 -> 0.12.0 #78355

merged 1 commit into from Jan 23, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 23, 2020

Motivation for this change

Changelog: https://github.com/Rigellute/spotify-tui/releases/tag/v0.12.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jwijenbergh January 23, 2020 12:27
jwijenbergh
jwijenbergh approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@jwijenbergh jwijenbergh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on my system (NixOS). Everything seems to be working fine. Thanks!

@marsam marsam merged commit 944236a into NixOS:master Jan 23, 2020
@marsam marsam deleted the update-spotify-tui branch January 23, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwijenbergh jwijenbergh jwijenbergh approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @jwijenbergh