Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lyx: 2.3.0 -> 2.3.4 #79114

Merged
merged 1 commit into from Feb 3, 2020
Merged

lyx: 2.3.0 -> 2.3.4 #79114

merged 1 commit into from Feb 3, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 2, 2020

Motivation for this change

2.3.3: https://www.mail-archive.com/lyx-announce@lists.lyx.org/msg00180.html
2.3.4: https://www.mail-archive.com/lyx-announce@lists.lyx.org/msg00181.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, and functions as expected on NixOS. Patch is removed.

@mmahut mmahut merged commit 8663b7b into NixOS:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants