Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: 1.40.0 -> 1.41.0 #79148

Merged
merged 1 commit into from Feb 9, 2020
Merged

rustc: 1.40.0 -> 1.41.0 #79148

merged 1 commit into from Feb 9, 2020

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Feb 3, 2020 •
edited

Motivation for this change

New rustc version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bkchr bkchr requested review from LnL7 and Mic92 as code owners February 3, 2020 08:10
@bkchr bkchr changed the base branch from master to staging February 3, 2020 08:10
@FRidh FRidh added this to WIP in Staging via automation Feb 5, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging Feb 5, 2020
@FRidh FRidh added this to the 20.03 milestone Feb 5, 2020
@Mic92
Copy link
Member

Mic92 commented Feb 7, 2020 •
edited

fd on x86_64-linux builds fine.
At least rustc builds on aarch64-linux.

@bkchr
Copy link
Contributor Author

bkchr commented Feb 7, 2020

Locally firefox also builds for me.

@Mic92
Copy link
Member

Mic92 commented Feb 7, 2020 •
edited

Does firefox uses this rust version at all? EDIT: it does.

@Mic92
Copy link
Member

Mic92 commented Feb 7, 2020

cc @alyssais Could you run nix-review -p fd 79148 on macOS?

@Mic92
Copy link
Member

Mic92 commented Feb 7, 2020

@GrahamcOfBorg build fd

@FRidh FRidh merged commit 60a479d into NixOS:staging Feb 9, 2020
Staging automation moved this from Needs review to Done Feb 9, 2020
@FRidh
Copy link
Member

FRidh commented Feb 9, 2020

By merging now we could get it in before branch-off. If there are issues we can always revert.

@LnL7
Copy link
Member

LnL7 commented Feb 9, 2020

My darwin build just finished, looks good.

@oxalica oxalica mentioned this pull request Feb 10, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Staging
  
Done
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkchr @Mic92 @FRidh @LnL7