Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: e3a9318b6fdb
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 0f10495eb9ff
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Nov 29, 2019

  1. nixos/networkd: mark units option as internal 

    The options at `systemd.network` (`links`, `netdevs` and `networks`) are
directly mapped to the three different unit types of `systemd-networkd(8)`.

However there's also the option `systemd.network.units` which is
basically used as a container for generated unit-configs that are linked
to `/etc/systemd/networkd`[1].

This should not be exposed to the user as it's unclear whether or not it
should be used directly which can be pretty confusing which is why I decided to
declare this option as internal (including all sub-options as `internal`
doesn't seem to be propagated to submodules).

[1] https://github.com/NixOS/nixpkgs/blob/9db75ed88fd87e17ec448ad7a43b62acb4842854/nixos/modules/system/boot/networkd.nix#L933-L937
    @Ma27
    Ma27 committed Nov 29, 2019
    Copy the full SHA
    60f2c59 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2020

  1. Merge pull request #74624 from Ma27/networkd-units-internal 

    nixos/networkd: mark `units` option as internal
    @Ma27
    Ma27 committed Feb 2, 2020
    Copy the full SHA
    0f10495 View commit details
    Browse the repository at this point in the history