Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/openstack-image: add stdenv to image for nixos-rebuild #79141

Merged
merged 2 commits into from Feb 3, 2020
Merged

nixos/tests/openstack-image: add stdenv to image for nixos-rebuild #79141

merged 2 commits into from Feb 3, 2020

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Fixes #79100

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested a review from nlewo February 3, 2020 16:58
@flokli
Copy link
Contributor

flokli commented Feb 3, 2020

@thefloweringash can you uncomment openstack-image-userdata from all-tests.nix and see if it works now?

@tfc
Copy link
Contributor

tfc commented Feb 3, 2020

@thefloweringash wow weird, i tried exactly the same thing before opening my issue and that did not work because the stdenv that i added had a different hash than the stdenv that the vm wanted to build... but i am happy to see it working now!

@flokli
Copy link
Contributor

flokli commented Feb 3, 2020

@GrahamcOfBorg test openstack-image-userdata openstack-image-metadata

@flokli flokli merged commit 136c0e4 into NixOS:master Feb 3, 2020
@flokli
Copy link
Contributor

flokli commented Feb 3, 2020

Thanks!

@thefloweringash
Copy link
Member Author

@thefloweringash wow weird, i tried exactly the same thing before opening my issue and that did not work because the stdenv that i added had a different hash than the stdenv that the vm wanted to build... but i am happy to see it working now!

That is odd. These type of tests aren’t easy to work on. For fixing up the amazon tests I landed up writing some hacky c++ using the nix api to print why things are required to be built, and slowly iterated until it didn’t require downloading anything. Fortunately this test is a lot less complicated.

@thefloweringash thefloweringash deleted the openstack-tests branch February 3, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc tfc approved these changes

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixosTests.openstack-image: Fails due to closure download
3 participants
@thefloweringash @flokli @tfc