Mpv plugin bookmark 20180320.lua #79092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfrankenau Can you review this PR? |
|
What is the difference between the upstream light and master branch? The former one is the default one. Also please squash those commits. |
Mic92
reviewed
Apr 30, 2020
| owner = "yozorayuki"; | ||
| repo = "mpv-plugin-bookmark"; | ||
| rev = "08fa0a415a4a220a91b8436ca681e3da92120b9d"; | ||
| sha256 = "0ann6c2rajy36a6w72l2q6288r6v03ha278i5qh5hk6r9q6gkhy8"; |
There was a problem hiding this comment.
You can return fetchFromGithub directly instead of wrapping it into a stdenv.mkDerivation.
Checksum also needs a fix in that case:
Suggested change
| sha256 = "0ann6c2rajy36a6w72l2q6288r6v03ha278i5qh5hk6r9q6gkhy8"; | |
| name = "mpv-plugin-bookmark-20180320.lua"; | |
| sha256 = "0ann6c2rajy36a6w72l2q6288r6v03ha278i5qh5hk6r9q6gkhy8"; | |
| postFetch = '' | |
| cp bookmark.lua $out | |
| ''; | |
| meta = with lib; { | |
| description = "mpv plugin to record your playing history for each folder and you can choose resume to play next time"; | |
| homepage = https://github.com/yozorayuki/mpv-plugin-bookmark; | |
| license = licenses.asl20; | |
| maintainers = [ maintainers.mschneider ]; | |
| }; |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
stalled please reopen, if you wish to continue working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpv-plugin-bookmark
mpv plugin for recording last play in current playing folder and you can resume to play
this plugin will also load the playlist from the playing folder automatically
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)