-
Notifications
You must be signed in to change notification settings - Fork 58
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: m-labs/nmigen
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c42c3a096f89
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: m-labs/nmigen
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7245b1e4c2c8
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 16 commits
- 17 files changed
- 5 contributors
Commits on Jan 27, 2020
-
whitequark authored
Jan 27, 2020 Configuration menu - View commit details
-
Copy full SHA for c280c7c - Browse repository at this point
Copy the full SHA c280c7cView commit details
Commits on Jan 31, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7792a6c - Browse repository at this point
Copy the full SHA 7792a6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec3a219 - Browse repository at this point
Copy the full SHA ec3a219View commit details -
Configuration menu - View commit details
-
Copy full SHA for b72c3fc - Browse repository at this point
Copy the full SHA b72c3fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ac13eb - Browse repository at this point
Copy the full SHA 3ac13ebView commit details -
hdl.dsl: make
if m.{If,Elif,Else}(...)
a syntax error.A common typo, and hard to notice when it's silently ignored. Fixes #284.
whitequark committedJan 31, 2020 Configuration menu - View commit details
-
Copy full SHA for 9964fc6 - Browse repository at this point
Copy the full SHA 9964fc6View commit details -
README: clarify relationship to Migen.
whitequark committedJan 31, 2020 Configuration menu - View commit details
-
Copy full SHA for a9da9ef - Browse repository at this point
Copy the full SHA a9da9efView commit details -
hdl.dsl: add missing case width check for Enum values.
Fixes #305.
whitequark committedJan 31, 2020 Configuration menu - View commit details
-
Copy full SHA for 687d3a3 - Browse repository at this point
Copy the full SHA 687d3a3View commit details
Commits on Feb 1, 2020
-
_unused: extract must-use logic from hdl.ir.
whitequark committedFeb 1, 2020 Configuration menu - View commit details
-
Copy full SHA for 9fb4a4f - Browse repository at this point
Copy the full SHA 9fb4a4fView commit details -
hdl.ast: warn on unused property statements (Assert, Assume, etc).
A property statement that is created but not added to a module is virtually always a serious bug, since it can make formal verification pass when it should not. Therefore, add a warning to it, similar to UnusedElaboratable. Doing this to all statements is possible, but many temporary ones are created internally by nMigen, and the extensive changes required to remove false positives are likely not worth the true positives. We can revisit this in the future. Fixes #303.
whitequark committedFeb 1, 2020 Configuration menu - View commit details
-
Copy full SHA for afece15 - Browse repository at this point
Copy the full SHA afece15View commit details -
hdl.dsl: don't allow inheriting from Module.
`Module` is an object with a lot of complex and sometimes fragile behavior that overrides Python attribute accessors and so on. To prevent user designs from breaking when it is changed, it is not supposed to be inherited from (unlike in Migen), but rather returned from the elaborate() method. This commit makes sure it will not be inherited from by accident (most likely by users familiar with Migen). Fixes #286.
whitequark committedFeb 1, 2020 Configuration menu - View commit details
-
Copy full SHA for 6fd7cba - Browse repository at this point
Copy the full SHA 6fd7cbaView commit details -
build.plat: align pipeline with Fragment.prepare().
Since commit 7257c20, platform code calls create_missing_domains() before _propagate_domains_up() (as a part of prepare() call). Since commit a7be3b4, without a platform, create_missing_domains() is calle after _propagate_domains_up(); because of that, it adds the missing domain to the fragment. When platform code then calls prepare() again, this causes an assertion failure. The true intent behind the platform code being written this way is that it *overrides* a part of prepare()'s mechanism. Because it was not changed when prepare() was modified in 7257c20, the override, which happened to work by coincidence, stopped working. This is now fixed by inlining the relevant parts of Fragment.prepare() into Platform.prepare(). This is not a great solution, but given the amount of breakage this causes (no platform-using code works), it is acceptable for now. Fixes #307.
whitequark committedFeb 1, 2020 Configuration menu - View commit details
-
Copy full SHA for cce6b86 - Browse repository at this point
Copy the full SHA cce6b86View commit details -
hdl.ast: prohibit shifts by signed value.
These are not desirable in a HDL, and currently elaborate to broken RTLIL (after YosysHQ/yosys#1551); prohibit them completely, like we already do for division and modulo. Fixes #302.
whitequark committedFeb 1, 2020 Configuration menu - View commit details
-
Copy full SHA for 49758a3 - Browse repository at this point
Copy the full SHA 49758a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a295e35 - Browse repository at this point
Copy the full SHA a295e35View commit details
Commits on Feb 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 60447a0 - Browse repository at this point
Copy the full SHA 60447a0View commit details -
Symbiotic EDA can get credit after they clarify the sitation with me; contact attempt on 29-JAN-2020 received no reply.
Configuration menu - View commit details
-
Copy full SHA for 7245b1e - Browse repository at this point
Copy the full SHA 7245b1eView commit details
There are no files selected for viewing