Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pandas: disable invalid tests #79131

Merged
merged 1 commit into from Feb 3, 2020
Merged

python3Packages.pandas: disable invalid tests #79131

merged 1 commit into from Feb 3, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 2, 2020 •
edited

Motivation for this change

closes #79107

util_in_top_level tries to import from pandas.tests.
This would be fine if running the tests pre-installation,
however, the tests directory isn't available after installation

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
python3Packages.pandas: disable invalid tests
ef138e2 
util_in_top_level tries to import from pandas.tests.
This would be fine if running the tests pre-installation,
however, the tests directory isn't available after installation
@jonringer jonringer requested a review from FRidh as a code owner February 2, 2020 22:27
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.pandas
@GrahamcOfBorg build python38Packages.pandas

@ofborg ofborg bot requested review from 7c6f434c and knedlsepp February 2, 2020 23:03
@jonringer
Copy link
Contributor Author

seeing as this fixes a broken build, I'm going to merge

@jonringer jonringer merged commit ff741a5 into NixOS:master Feb 3, 2020
@jonringer jonringer deleted the fix-pandas branch February 3, 2020 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python3Packages.pandas is broken
1 participant
@jonringer