New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash in crash handler - Assertion failed at line 2981 of window.cpp #7970
Comments
Extremely difficult to tell what's happened here given just an assertion. Looking at the code, this function is HandleMouseEvents. This is only called from InputLoop (which is guarded by the same assertion, so it can't be that), and then several places in the win32 video driver, which I must presume you're using. These places are all relating mouse button presses or movements, so I guess you might have more luck reproducing it with lots of those? As for the failure itself, Hopefully that helps you reproduce whatever's happening :) Ideally we'd fix the issue in the crash handler first, then fix whatever is causing the crash... |
Going to close this for now, as there's been no other instances of it, and no way of reproducing it either. Feel free to comment/request reopen if you come up with anything more concrete |
Tested on 2020-05-09 master:
Note that this is on Windows 10 64-bit. Additional valid reproduction steps.
|
Ah yes it's when the mouse moves over openttd window while the crash dialog is open. Lines 1376 to 1397 in 800ade7
CallVehicleTicks()
|
I've encountered this before, this commit JGRennison/OpenTTD-patches@102405e is a mitigation. |
Version of OpenTTD
Last tested: d7a928a-windows-win32 (Windows 7 Ultimate)
Expected result
No crash in crash handler
Actual result
Crash in crash handler -
Assertion failed at line 2981 of window.cpp: HasModalProgress() || IsLocalCompany()
No crash log created (a crash in the crash handler does not produce a crash log).
Steps to reproduce
??? (Seems to randomly occur, especially with starting new games, testing scripts, loading games, saving the config, etc.)
The text was updated successfully, but these errors were encountered: