New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bs-platform: fix build on aarch64 #79106
Conversation
configurePhase = '' | ||
node scripts/ninja.js config | ||
''; | ||
dontConfigure = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tracked down the issue that @bobzhang referred to in this comment.
Apparently running node scripts/ninja.js config
will cause the build script to build the development version.
Looks like we can build bs-platform on aarch64 again. Thanks for your help @bobzhang! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit msg should be:
bs-platform: 7.0.1 -> 7.1.0
eba938f
to
be76781
Compare
Thanks, updated |
rev = "52770839e293ade2bcf187f2639000ca0a9a1d46"; | ||
sha256 = "0s7g2zfhshsilv9zyp0246bypg34d294z27alpwz03ws9608yr7k"; | ||
rev = "a7f482243fabb38292b81b7bae9cefcb8076237f"; | ||
sha256 = "0p0ywb4cjpsrjq0if4s1bsnv9jdycd61r4ryndfzc50gngrpjbqr"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fails for me:
fatal: reference is not a tree: a7f482243fabb38292b81b7bae9cefcb8076237f
Unable to checkout a7f482243fabb38292b81b7bae9cefcb8076237f from https://github.com/BuckleScript/bucklescript.git.
@anmonteiro 7.1.0 seems not to be released. Further more git commits of development version are changing so referencing those commits is not safe. We need to wait for the official release of 7.1.0 and commit that will stay in the master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait for 7.1.0 release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend leaving bump of version out from this and merging it as a fix for arm build. If you chose to do so please change the commit message. @jonringer 's suggested name follows convention in case of updates but not if we leave it out.
@@ -4,14 +4,14 @@ let | |||
in | |||
(build-bs-platform { | |||
inherit stdenv runCommand fetchFromGitHub ninja nodejs python3; | |||
version = "7.0.1"; | |||
version = "7.1.0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert version bump:
version = "7.1.0"; | |
version = "7.0.1"; |
ocaml-version = "4.06.1"; | ||
|
||
src = fetchFromGitHub { | ||
owner = "BuckleScript"; | ||
repo = "bucklescript"; | ||
rev = "52770839e293ade2bcf187f2639000ca0a9a1d46"; | ||
sha256 = "0s7g2zfhshsilv9zyp0246bypg34d294z27alpwz03ws9608yr7k"; | ||
rev = "a7f482243fabb38292b81b7bae9cefcb8076237f"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert to old commit:
rev = "a7f482243fabb38292b81b7bae9cefcb8076237f"; | |
rev = "52770839e293ade2bcf187f2639000ca0a9a1d46"; |
rev = "52770839e293ade2bcf187f2639000ca0a9a1d46"; | ||
sha256 = "0s7g2zfhshsilv9zyp0246bypg34d294z27alpwz03ws9608yr7k"; | ||
rev = "a7f482243fabb38292b81b7bae9cefcb8076237f"; | ||
sha256 = "0p0ywb4cjpsrjq0if4s1bsnv9jdycd61r4ryndfzc50gngrpjbqr"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert checksum:
sha256 = "0p0ywb4cjpsrjq0if4s1bsnv9jdycd61r4ryndfzc50gngrpjbqr"; | |
sha256 = "0s7g2zfhshsilv9zyp0246bypg34d294z27alpwz03ws9608yr7k"; |
be76781
to
642e62e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
@anmonteiro can you please rebase and sqush commits in here? It seems to me that once that's done we can start pushing for merge. |
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
592fa02
to
56dcbc3
Compare
Squashed! |
Thanks! |
Motivation for this change
rescript-lang/rescript-compiler#4139
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)cc @turboMaCk