Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hercules: init at 3.13 (attempt 2) #79069

Merged
merged 1 commit into from Mar 26, 2020
Merged

Conversation

anna328p
Copy link
Member

@anna328p anna328p commented Feb 2, 2020

Motivation for this change

Add the Hercules IBM mainframe emulator to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

jonringer commented Mar 17, 2020

@GrahamcOfBorg eval

@anna328p
Copy link
Member Author

@jonringer This fails because the packages are served over HTTP and the CI doesn't want to fetch the HTTP source because it's in restricted mode

@jonringer
Copy link
Contributor

interesting. cc @grahamc opinions?

@lightdiscord
Copy link
Member

lightdiscord commented Mar 20, 2020

HTTP url seems to work with the bot.
For example here is an HTTP url and here is the PR and it seems the bot (ofborg) works fine.

The problem may come because you're using builtins.fetchurl instead of pkgs.fetchurl ?

@anna328p
Copy link
Member Author

@jonringer @lightdiscord updated, hopefully it works

@anna328p
Copy link
Member Author

@jonringer resolved

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

https://github.com/NixOS/nixpkgs/pull/79069
1 package built:
hercules

@jonringer
Copy link
Contributor

@GrahamcOfBorg build hercules

@jonringer jonringer merged commit e882dfe into NixOS:master Mar 26, 2020
@anna328p anna328p deleted the hercules branch March 26, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants