Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6566: Fix signed integer overflow in viewport draw area chunking #7968

Merged
merged 1 commit into from Feb 2, 2020
Merged

Fix #6566: Fix signed integer overflow in viewport draw area chunking #7968

merged 1 commit into from Feb 2, 2020

Conversation

JGRennison
Copy link
Contributor

This caused drawing areas larger than 2097151 pixels at 8x zoom to
not be subdivided into smaller chunks as required.
This resulted in pathological performance issues in the sprite sorter.

@JGRennison
Fix OpenTTD#6566: Fix signed integer overflow in viewport draw area c…
2dc62f8 
…hunking

This caused drawing areas larger than 2097151 pixels at 8x zoom to
not be subdivided into smaller chunks as required.
This resulted in pathological performance issues in the sprite sorter.
LordAro
LordAro approved these changes Feb 2, 2020
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha. LGTM

@nielsmh nielsmh merged commit 14af870 into OpenTTD:master Feb 2, 2020
@ldpl ldpl mentioned this pull request Feb 14, 2020
Merged
@JGRennison JGRennison deleted the fix-issue-6566 branch January 9, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JGRennison @LordAro @nielsmh