New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
icepeak: init at 0.7.2 #79155
icepeak: init at 0.7.2 #79155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
structure of this is a little non-standard, but I'm also not super familiar with haskell packaging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try to get upstream to release this to hackage?
If they do so, then this will be automatically available in nixpkgs and we will hopefully not have to do any work to keep it updated.
If upstream doesn't want to upload to hackage, then there are a couple things that should be changed here.
The biggest thing is that this file should be generated automatically with cabal2nix
. Take a look at how spago
is packaged, and try to replicate that.
To keep the Nix file in line with the one in the repo you could write a |
Thanks, I'll give this a try. I also started the process to upload the package to Hackage (currently waiting for approval). Would that still be preferable? |
Yes, in general it is preferable to just get Haskell packages from Hackage (since the updating process is automatic). |
Okay, I'll move forward with that then. Out of curiosity: How does the Hackage <-> Nixpkgs synchronizing process work? Does it simply pick the latest version on Hackage? Or does it also make use of Stackage snapshots somehow? |
@rkrzr I believe I wrote about this in the following post: https://discourse.nixos.org/t/haskellpackages-stm-containers-fails-to-build/5416/4 If not, then you should probably be able to find an explanation about it in one of my past posts here or on discourse. |
Alright, I now rebased this one more time on (Apologies to all the people who were automatically added as reviewers to this PR, I accidentally rebased on the wrong upstream first, which added everyone automatically. It seems that I cannot unselect reviewers again, so best to just ignore this PR, I guess) |
@rkrzr This is looking good, but you'll need to do one more thing. Please mark Here's a video showing how to do this: https://discourse.nixos.org/t/video-tutorial-how-to-fix-broken-haskell-packages-in-nix/3968 |
b237640
to
d02ac6c
Compare
Also, add myself to the maintainers section for Haskell modules coming from Hackage.
Ok, I've rebased this one more time and marked |
@rkrzr Looks like everything builds now, thanks for following up on this! |
Icepeak is a fast JSON document store with push notification support.
Motivation for this change
Icepeak is one of our open-source projects and we would like to get it added to nixpkgs so that other people can install it with nix, instead of having to compile from source.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)