Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-xmpp-alerts: fix evaluation #79147

Merged
merged 1 commit into from Feb 3, 2020
Merged

prometheus-xmpp-alerts: fix evaluation #79147

merged 1 commit into from Feb 3, 2020

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Feb 3, 2020

callPackages adds override functions to each attribute rather than just
the top-level drv resulting drv.metadata that includes a function.

derivation 'prometheus-xmpp-alerts-0.4.2' has invalid meta attribute 'overrideDerivation'
Motivation for this change

https://hydra.nixos.org/build/111462401

/cc @fpletz

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LnL7
prometheus-xmpp-alerts: fix evaluation
105ecf1 
https://hydra.nixos.org/build/111462401

callPackages adds override functions to each attribute rather than just
the top-level drv resulting drv.metadata that includes a function.

    derivation 'prometheus-xmpp-alerts-0.4.2' has invalid meta attribute 'overrideDerivation'
@LnL7 LnL7 mentioned this pull request Feb 3, 2020
Open
@Ma27 Ma27 merged commit a87e373 into NixOS:master Feb 3, 2020
@LnL7 LnL7 deleted the fix-metrics branch February 3, 2020 09:38
@fpletz
Copy link
Member

fpletz commented Feb 3, 2020

Oops. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @fpletz @Ma27