Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firejail: system package on programs.firejail.enable #79104

Merged
merged 1 commit into from Mar 13, 2020
Merged

firejail: system package on programs.firejail.enable #79104

merged 1 commit into from Mar 13, 2020

Conversation

snicket2100
Copy link
Contributor

this way the man page etc. becomes available if we enable firejail with
programs.firejail.enable = true

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@snicket2100
firejail: system package on programs.firejail.enable
045f8e2 
this way the man page etc. becomes available if we enable firejail with
`programs.firejail.enable = true`
mmilata
mmilata approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm & manpages are useful

@alyssais alyssais merged commit 65abd80 into NixOS:master Mar 13, 2020
@ryneeverett ryneeverett mentioned this pull request Apr 18, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snicket2100 @mmilata @alyssais