Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installation-cd-graphical-base.nix: adding git #79098

Merged
merged 1 commit into from Feb 14, 2020
Merged

installation-cd-graphical-base.nix: adding git #79098

merged 1 commit into from Feb 14, 2020

Conversation

snicket2100
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@snicket2100 snicket2100 mentioned this pull request Feb 2, 2020
Closed
@worldofpeace
Copy link
Contributor

I believed we discussed also adding mercurial here as well if it's for the graphical image.
cc @alyssais @grahamc @edolstra

@grahamc
Copy link
Member

grahamc commented Feb 3, 2020 via email

@danbst
Copy link
Contributor

danbst commented Feb 3, 2020

@snicket2100 I believe pkgs.git would work here as well, is there any particular reason for gitFull?

@edolstra
Copy link
Member

edolstra commented Feb 3, 2020

I don't see a reason to add Mercurial. Git is probably fine. What's the impact on the size of the ISO?

@snicket2100
Copy link
Contributor Author

@danbst No, there wasn't any particular reason to use gitFull. I have changed it to git.

The impact on the size of the ISO is ~ 14MiB.

@snicket2100 snicket2100 force-pushed the git-to-graphical-installation-cd branch from a9847b7 to 7a2f512 Compare February 5, 2020 22:51
@danbst
Copy link
Contributor

danbst commented Feb 10, 2020

part of the increased closure size is because of static linking of every Git binary: https://marc.info/?l=git&m=156028332301884&w=2

ncdu 1.14 ~ Use the arrow keys to navigate, press ? for help                                                                                                                                  
--- /nix/store/sgygk97cmx6wz2mr7x83spnkc5j5cg7m-git-2.21.0/libexec/git-core ------------------------------------------------------------------------------------------------------------------
                         /..
    2,9 MiB [##########]  git
    1,7 MiB [#####     ]  git-imap-send
    1,7 MiB [#####     ]  git-remote-http
    1,7 MiB [#####     ]  git-http-push
    1,7 MiB [#####     ]  git-http-fetch
    1,7 MiB [#####     ]  git-fast-import
    1,7 MiB [#####     ]  git-remote-testsvn
    1,6 MiB [#####     ]  git-daemon
    1,6 MiB [#####     ]  git-credential-cache--daemon
    1,6 MiB [#####     ]  git-http-backend
    1,6 MiB [#####     ]  git-credential-store                                                                                                                                                
    1,6 MiB [#####     ]  git-credential-cache
    1,6 MiB [#####     ]  git-sh-i18n--envsubst
    1,6 MiB [#####     ]  git-shell
  160,0 KiB [          ]  git-cvsserver

@danbst danbst merged commit 50a597c into NixOS:master Feb 14, 2020
@worldofpeace
Copy link
Contributor

Thanks @danbst

@snicket2100 snicket2100 deleted the git-to-graphical-installation-cd branch February 24, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@snicket2100 @worldofpeace @grahamc @danbst @edolstra @Ma27