pyopengl: fix runtime shared library loading failure with 3.1.4 #79154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guibou
changed the title
guibou
changed the title
jonringer
reviewed
Feb 3, 2020
This closes NixOS#76822. pyopengl 3.1.4 introduced a new logic for shared library loading: it tests a few combinations of library name and suffix (such as .so.X). Our previous patch was just replacing the library name (e.g. 'glut') by the full path to the nix store. This does not work anymore with pyopengl 3.1.4 new heuristic. This commit just keep the behavior of pyopengl but adds the nix store path to the list of tried paths.
|
@jonringer done. |
|
this may want to be upstreamed |
|
@jonringer I don't know what can be upstreamed here, but I'll think about it. Do you think this is a blocker for this commit? |
|
this could be upstreamed: from your comment it seems that they went away from this approach. I'm not sure how name is derived, but I'm assuming checking 1 additional item wouldn't hurt too much. not a blocker, stuff like this happens all the time. |
|
It's taking a while to review because pyopengl is used by some heavy-weight packages, and my laptop I travel with isn't super powerful. |
|
Any update? |
|
sorry, there was a bunch of blocking issues with some downstream packages which made it hard to do a review |
jonringer
approved these changes
Feb 24, 2020
There was a problem hiding this comment.
diff LGTM
no regressions
[62 built (6 failed), 1 copied (513.2 MiB), 71.2 MiB DL]
error: build of '/nix/store/c9niqv7qhgh21hi2bplyy4by4fk9dagm-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/79154
12 package marked as broken and skipped:
cq-editor gazebo gazebo-headless gazeboSimulator.gazebo6 gazeboSimulator.gazebo6-headless gazeboSimulator.gazebo7 gazeboSimulator.gazebo7-headless python27Packages.runsnakerun python27Packages.squaremap python37Packages.spyder python38Packages.spyder spyder
5 package failed to build:
ib-controller python37Packages.rl-coach python38Packages.rl-coach salut_a_toi sasview
54 package built:
curaByDagoma cura_stable displaycal friture gnss-sdr gnuradio gnuradio-with-packages gqrx gr-ais gr-gsm gr-limesdr gr-nacl gr-osmosdr gr-rds grass impressive inspectrum kicad kicad-small kicad-unstable loxodo mavproxy metamorphose2 playonlinux plover.stable printrun python27Packages.binwalk python27Packages.pyopengl python27Packages.pyqtgraph python27Packages.pyspread python27Packages.robotframework-ride python27Packages.spyder python27Packages.wxPython python27Packages.wxPython_4_0 python37Packages.binwalk python37Packages.pyopengl python37Packages.pyqtgraph python37Packages.stytra python37Packages.wxPython_4_0 python38Packages.binwalk python38Packages.pyopengl python38Packages.pyqtgraph python38Packages.stytra python38Packages.wxPython_4_0 qradiolink qutebrowser run-scaled scyther soulseekqt torchat tribler video2midi winpdb xpra
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #76822.
pyopengl 3.1.4 introduced a new logic for shared library loading: it
tests a few combinations of library name and suffix (such as .so.X).
Our previous patch was just replacing the library name (e.g. 'glut') by
the full path to the nix store. This does not work anymore with pyopengl
3.1.4 new heuristic.
This commit just keep the behavior of pyopengl but adds the nix store
path to the list of tried paths.
I tested with
friturewhich was failing at build time before this commit and is now building. I also testedpyqtgraphwhich was failing at runtime and is now working.Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)