Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kristian-brucaj to maintainer-list #79124

Merged
merged 3 commits into from Feb 2, 2020
Merged

Add kristian-brucaj to maintainer-list #79124

merged 3 commits into from Feb 2, 2020

Conversation

Flameslice
Copy link
Contributor

Looking to work on maintaining a few new packages

Motivation for this change

Added kristian-brucaj to maintainer list

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [X ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [X ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented Feb 2, 2020

Great! Welcome to the team. I took the liberty to squash your commits (removing the reverted commit) and change the commit message to the standard maintainers: add xyz (see git log maintainer-list.nix).

I look forward to your contributions :)

@timokau timokau merged commit 2f220a6 into NixOS:master Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Flameslice @timokau