Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editorconfig-checker: 2.0.2 -> 2.0.3 #79145

Merged
merged 1 commit into from Feb 3, 2020
Merged

editorconfig-checker: 2.0.2 -> 2.0.3 #79145

merged 1 commit into from Feb 3, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Feb 3, 2020 •
edited

Motivation for this change

Bump to the latest version [0] and additionally fix package build as it's failing currently with module hash mismatch:

hash mismatch in fixed-output derivation '/nix/store/6ghdnnzr7w8ah9p6pym8mik67bp580jy-editorconfig-checker-2.0.2-go-modules':
  wanted: sha256:09b1v9gyh6827yqlfxxxq3lcqhd5snn3n7gdlbjmga3wyp2x4g2r
  got:    sha256:1iiv12ginb3ky739z7v8wf4z5lv24gmghbybs3lzay0kqn449n4x
cannot build derivation '/nix/store/dhickjqkym3hgr7ispji7yi7argwbnpj-editorconfig-checker-2.0.2.drv': 1 dependencies couldn't be built

[0] https://github.com/editorconfig-checker/editorconfig-checker/releases/tag/2.0.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@ofborg ofborg bot requested review from uri-canva and kalbasit February 3, 2020 05:35
@uri-canva
Copy link
Contributor

fix package build as it's failing currently with module hash mismatch

That's strange, it has a go.sum file so the modules should be completely reproducible.

I don't have merge permissions so I can't merge this, but it looks good to me.

@Frostman
Copy link
Member Author

Frostman commented Feb 3, 2020

@uri-canva yeah, that's quite strange, I have no idea how it could happen with go.sum in the repo...

@Frostman Frostman mentioned this pull request Feb 3, 2020
Merged
10 tasks
jonringer
jonringer approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
executable shows usage

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79145
1 package built:
editorconfig-checker

@jonringer jonringer merged commit 18daf2f into NixOS:master Feb 3, 2020
@jonringer
Copy link
Contributor

fix package build as it's failing currently with module hash mismatch

That's strange, it has a go.sum file so the modules should be completely reproducible.

I don't have merge permissions so I can't merge this, but it looks good to me.

Sometimes the way the git objects are packed can affected the sha (generally only an issue with fetchgit+deepClone). Also darwin has some text unicode normalization which can also affect the sha.

@Frostman Frostman deleted the editorconfig-checker-2.0.3 branch February 3, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@uri-canva uri-canva uri-canva approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frostman @uri-canva @jonringer