Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

saltine: fix build by disabling tests #82041

Merged
merged 1 commit into from Mar 8, 2020
Merged

saltine: fix build by disabling tests #82041

merged 1 commit into from Mar 8, 2020

Conversation

timds
Copy link
Contributor

@timds timds commented Mar 8, 2020

Motivation for this change

The tests fail to compile because of a missing module but would otherwise be fine. I opened a PR in the repo but I'm not sure how long it will take for a new release, and whether it's expected that nixpkgs should just wait for upstream fixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timds
saltine: fix build by disabling tests
6b2803a 
The tests fail to compile because of a missing module but would
otherwise be fine.
@cdepillabout cdepillabout merged commit a49c19d into NixOS:haskell-updates Mar 8, 2020
@cdepillabout
Copy link
Member

Thanks. This builds for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timds @cdepillabout