Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bs-platform: 7.0.1 -> 7.2.0 #82068

Merged
merged 3 commits into from Mar 14, 2020

Conversation

anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Mar 8, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@turboMaCk turboMaCk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested on NixOS
    just few questions before we go ahead with merge.

BS_RELEASE_BUILD = "true";
BS_TRAVIS_CI = "1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on why we need this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason (cf rescript-lang/rescript-compiler#4183) BuckleScript added yet another idiosyncrasy to its build / release process. This environment variable allows the intermediate artifacts of the stdlib to be built so that editor auto completion works, for example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explanation! I would probably add some short comment about this as it's really non obvious from code itself. Thanks

cp bsconfig.json package.json $out
ln -s $out/lib/bsb $out/bin/bsb
ln -s $out/lib/bsc $out/bin/bsc
ln -s $out/lib/bsrefmt $out/bin/bsrefmt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bsrefmt is gone?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably an oversight. I’ll check soon!

@anmonteiro
Copy link
Member Author

@turboMaCk addressed your code review.

@ofborg ofborg bot requested a review from turboMaCk March 9, 2020 17:27
Copy link
Member

@turboMaCk turboMaCk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Copy link
Member

@gamb gamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Built on MacOS too 👍

@anmonteiro
Copy link
Member Author

@jonringer could I request a merge from you?

@marsam marsam merged commit 8a0c1b8 into NixOS:master Mar 14, 2020
@marsam
Copy link
Contributor

marsam commented Mar 14, 2020

Thanks!

@jonringer
Copy link
Contributor

sorry, haven't had as much free time lately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants