Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dune: 2.3.1 -> 2.4.0 #82069

Merged
merged 1 commit into from Mar 11, 2020
Merged

dune: 2.3.1 -> 2.4.0 #82069

merged 1 commit into from Mar 11, 2020

Conversation

anmonteiro
Copy link
Member

@anmonteiro anmonteiro commented Mar 8, 2020 •
edited

Motivation for this change

https://github.com/ocaml/dune/releases/tag/2.4.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @marsam @vbgl

@ofborg ofborg bot requested review from marsam and vbgl March 8, 2020 18:13
@vbgl
Copy link
Contributor

vbgl commented Mar 8, 2020 •
edited

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_08.phylogenetics

@vbgl
Copy link
Contributor

vbgl commented Mar 9, 2020

@GrahamcOfBorg build ocamlPackages.eigen

vbgl
vbgl requested changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks eigen on darwin.

@anmonteiro
Copy link
Member Author

So what’s the plan generally in cases like this? Wait for a next version of either that makes them work together?

@vbgl
Copy link
Contributor

vbgl commented Mar 9, 2020

This might be reported upstream.

You can also look for a workaround or mark the package as broken.

@marsam
Copy link
Contributor

marsam commented Mar 11, 2020

eigen is also failing on darwin in master, it should be fixed by #82299

@marsam marsam mentioned this pull request Mar 11, 2020
Closed
@vbgl
Copy link
Contributor

vbgl commented Mar 11, 2020

Apologies for wrongly blaming this PR.

@vbgl vbgl merged commit c9fc7a2 into NixOS:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anmonteiro @vbgl @marsam