Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocsigen-i18n: 3.4.0 → 3.5.0 #81964

Merged
merged 1 commit into from
Mar 8, 2020
Merged

ocsigen-i18n: 3.4.0 → 3.5.0 #81964

merged 1 commit into from
Mar 8, 2020
+5 −6

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Mar 7, 2020

Motivation for this change

Compatibility with OCaml 4.08

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@vbgl vbgl added 8.has: package (update) This PR updates a package to a newer version 6.topic: ocaml labels Mar 7, 2020
@ofborg ofborg bot requested a review from FlorentBecker March 7, 2020 09:33
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 7, 2020
@vbgl vbgl merged commit 5e468ef into NixOS:master Mar 8, 2020
@vbgl vbgl deleted the ocsigen-i18n branch March 8, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentBecker FlorentBecker

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vbgl