argocd: Fix stuck login command #82009
Conversation
shahrukh330
force-pushed
the
argo-fix-login-cmd
branch
from
269a2ca to
c8a3843
Compare
ofborg
bot
added
11.by: package-maintainer
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
|
still important to me |
stale
bot
removed
the
2.status: stale
| @@ -16,7 +16,7 @@ buildGoModule rec { | |||
|
|
|||
| nativeBuildInputs = [ packr ]; | |||
|
|
|||
| patches = [ ./use-go-module.patch ]; | |||
| patches = [ ./use-go-module.patch ./fix-login-cmd.patch ]; | |||
There was a problem hiding this comment.
Is this an upstream patch?
| @@ -16,7 +16,7 @@ buildGoModule rec { | |||
|
|
|||
| nativeBuildInputs = [ packr ]; | |||
|
|
|||
| patches = [ ./use-go-module.patch ]; | |||
| patches = [ ./use-go-module.patch ./fix-login-cmd.patch ]; | |||
|
|
|||
| buildFlagsArray = '' | |||
| -ldflags= | |||
There was a problem hiding this comment.
| -ldflags= | |
| -ldflags= | |
| -s | |
| -w |
|
@shahrukh330 please fix the merge conflict. |
SuperSandro2000
added
the
2.status: merge conflict
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
I believe this is no longer needed because I'm able to login fine with ArgoCD v2 so I'm closing this PR. |
Motivation for this change
Moving to go modules introduced a bug due to dependency mismatch. login command used to get stuck indefinitely.
Things done
Patches out problematic part of the code as a temp hack.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)