nemu: init at 2.6.0 #82004

matthiasbeyer · 2020-03-07T18:41:57Z

Can someone help me with the install step here?

Things done

doronbehar · 2020-03-08T08:50:22Z

pkgs/applications/misc/nemu/default.nix

+    ++ (lib.optional withDbus "-DNM_WITH_DBUS=ON")
+    ;
+
+  installPhase = ''


Upstream doesn't know how to write CMakeLists.txt. The following warning messages in configurePhase indicate this:

CMake Warning: Manually-specified variables were not used by the project: BUILD_TESTING CMAKE_CXX_COMPILER CMAKE_EXPORT_NO_PACKAGE_REGISTRY CMAKE_INSTALL_BINDIR CMAKE_INSTALL_DOCDIR CMAKE_INSTALL_INCLUDEDIR CMAKE_INSTALL_INFODIR CMAKE_INSTALL_LIBDIR CMAKE_INSTALL_LIBEXECDIR CMAKE_INSTALL_LOCALEDIR CMAKE_INSTALL_MANDIR CMAKE_INSTALL_OLDINCLUDEDIR CMAKE_INSTALL_SBINDIR

And it's notable when reading this:

https://github.com/nemuTUI/nemu/blob/1633a9ecb2b9b036a01a5dbeddb21787680064ec/CMakeLists.txt#L24-L36

I say - report this upstream and once fixed, use a fetchpatch remove the installPhase override.

In particular, most of these are caused not using GNUInstallDirs cmake module.

We updated our CMakeLists.txt
nemuTUI/nemu@a3f179a

Can you guys check if it's ok in current state, if so, we can make a new release for your package

Evaluation has failed: https://gist.github.com/f2bfb5498488aa5d2895bcbcace14e8d because of libudev argument not suppliled.

@matthiasbeyer please fix the inputs.

caadar · 2020-03-10T19:49:35Z

Ah! Some time ago tried packaging nEMU but not finished it...
You may look at my nemu-nix if interested.

stale · 2020-09-07T16:39:18Z

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

SuperSandro2000 · 2020-12-29T03:23:47Z

@ofborg eval

doronbehar · 2020-12-30T06:43:45Z

@GrahamcOfBorg eval

pkgs/applications/misc/nemu/default.nix

SuperSandro2000 · 2021-01-18T00:08:00Z

pkgs/applications/misc/nemu/default.nix

+    substituteInPlace src/nm_cfg_file.c --replace \
+'            nm_str_format(&qemu_bin, "%s/bin/qemu-system-%s",
+                NM_STRING(NM_USR_PREFIX), token);' \
+'            nm_str_format(&qemu_bin, "/run/wrappers/bin/qemu-system-%s", token);'


I would prefer a patch for this to prevent bit rot.

SuperSandro2000 · 2021-01-18T00:08:06Z

pkgs/applications/misc/nemu/default.nix

+    substituteInPlace src/nm_machine.c --replace \
+'    nm_str_format(&buf, "%s/bin/qemu-system-%s",
+        NM_STRING(NM_USR_PREFIX), arch);' \
+'    nm_str_format(&buf, "/run/wrappers/bin/qemu-system-%s", arch);'


I would prefer a patch for this to prevent bit rot.

SuperSandro2000 · 2021-01-18T00:08:18Z

pkgs/applications/misc/nemu/default.nix

+    platforms = with stdenv.lib.platforms; linux;
+  };
+}
+


One final new line to much.

pkgs/applications/misc/nemu/default.nix

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>

pkgs/applications/misc/nemu/default.nix

Just leave me alone with this bikeshedding for gods sake. Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

doronbehar · 2021-04-02T10:12:39Z

pkgs/applications/misc/nemu/default.nix

+, pkg-config
+, gettext
+, libpthreadstubs
+, libudev


libudev is an alias to udev, switch to using udev so ofborg eval won't fail:

https://gist.github.com/GrahamcOfBorg/0f0eac15e861b506912834b1000a8133

doronbehar · 2021-04-02T10:15:23Z

pkgs/applications/misc/nemu/default.nix

+
+  preConfigure = ''
+    patchShebangs .
+    substituteInPlace CMakeLists.txt --replace 'USR_PREFIX "/usr"' "USR_PREFIX \"$(out)\""


I see upstream has improved a bit their usage of CMake, but this is still present, it'd be nice to try to contribute upstream a more non-FHS friendly change for their CMakeLists.txt.

stale · 2021-10-01T23:25:32Z

I marked this as stale due to inactivity. → More info

doronbehar · 2021-10-02T06:44:43Z

@matthiasbeyer are you still interested in this? Upstream has released version 3.0.0 and it seems that now they support non-FHS file systems with some cmake flags so your expression can look much cleaner.

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Mar 7, 2020

doronbehar reviewed Mar 8, 2020

View reviewed changes

matthiasbeyer mentioned this pull request Mar 8, 2020

Fix CMakeLists.txt for packaging nemuTUI/nemu#37

Closed

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 7, 2020

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 29, 2020

SuperSandro2000 requested changes Jan 18, 2021

View reviewed changes

matthiasbeyer force-pushed the add-nemu branch from 80fc7cf to 2429ad0 Compare January 20, 2021 15:05

SuperSandro2000 reviewed Jan 20, 2021

View reviewed changes

pkgs/applications/misc/nemu/default.nix Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Jan 20, 2021

View reviewed changes

pkgs/applications/misc/nemu/default.nix Outdated Show resolved Hide resolved

matthiasbeyer force-pushed the add-nemu branch from 707ff95 to ef71c85 Compare February 1, 2021 14:33

nemu: init at 2.6.0

f7146be

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>

matthiasbeyer force-pushed the add-nemu branch from ef71c85 to f7146be Compare April 1, 2021 12:08

matthiasbeyer changed the title ~~nemu: Init at 2.3.0~~ nemu: init at 2.6.0 Apr 1, 2021

matthiasbeyer requested review from doronbehar and jtojnar April 1, 2021 12:10

SuperSandro2000 reviewed Apr 1, 2021

View reviewed changes

pkgs/applications/misc/nemu/default.nix Outdated Show resolved Hide resolved

Update pkgs/applications/misc/nemu/default.nix

1a082ef

Just leave me alone with this bikeshedding for gods sake. Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

doronbehar reviewed Apr 2, 2021

View reviewed changes

fixup! nemu: init at 2.6.0

302773e

ofborg bot added the 10.rebuild-linux: 1 label Apr 2, 2021

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 1, 2021

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 2, 2021

matthiasbeyer closed this Oct 2, 2021

matthiasbeyer deleted the add-nemu branch October 2, 2021 16:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nemu: init at 2.6.0 #82004

nemu: init at 2.6.0 #82004

matthiasbeyer commented Mar 7, 2020

doronbehar Mar 8, 2020

jtojnar Mar 8, 2020

grafin Mar 11, 2020

doronbehar Mar 11, 2020

SuperSandro2000 Jan 1, 2021

caadar commented Mar 10, 2020

stale bot commented Sep 7, 2020

SuperSandro2000 commented Dec 29, 2020

doronbehar commented Dec 30, 2020

SuperSandro2000 Jan 18, 2021

SuperSandro2000 Jan 18, 2021

SuperSandro2000 Jan 18, 2021

doronbehar Apr 2, 2021

doronbehar Apr 2, 2021

stale bot commented Oct 1, 2021

doronbehar commented Oct 2, 2021

nemu: init at 2.6.0 #82004

nemu: init at 2.6.0 #82004

Conversation

matthiasbeyer commented Mar 7, 2020

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caadar commented Mar 10, 2020

stale bot commented Sep 7, 2020

SuperSandro2000 commented Dec 29, 2020

doronbehar commented Dec 30, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Oct 1, 2021

doronbehar commented Oct 2, 2021