[20.03] dhall-nix: Fix build #81970
Merged
[20.03] dhall-nix: Fix build #81970
+8
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build dhall-nix |
ofborg
bot
added
6.topic: haskell
8.has: package (new)
cdepillabout
reviewed
Mar 7, 2020
Comment on lines
+1054
to
+1056
| dontCheck (super.dhall_1_29_0.overrideScope (self: super: { | ||
| prettyprinter = self.prettyprinter_1_6_0; | ||
| prettyprinter-ansi-terminal = | ||
| self.prettyprinter-ansi-terminal.override { | ||
| prettyprinter = self.prettyprinter_1_6_0; | ||
| }; | ||
| }); | ||
| })); |
There was a problem hiding this comment.
Thanks for cleaning this up.
I didn't realize that overrideScope was the tool to use here, but after seeing this example, I'll try to use it when appropriate!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #81834
The fix on master is different, but I'll do that too once haskell-nix/hnix-store#55 (comment) is ready
I also simplified some related overrides using
overrideScopeI updated
haskell-packages.nixto unmark it as broken, since it doesn't get updates anymore on this branchThings done
dhall-nixandhaskellPackages.dhall-nixsuccessfully on NixOS