Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

persistent-mysql: fix build #82072

Merged
merged 1 commit into from Mar 10, 2020
Merged

persistent-mysql: fix build #82072

merged 1 commit into from Mar 10, 2020

Conversation

jerith666
Copy link
Contributor

tests need a running mysql instance, so disable them

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

@jerith666 Could you rebase this on top of the haskell-updates branch instead of master?

@jerith666
persistent-mysql: fix build
fe4741a 
tests need a running mysql instance, so disable them
@jerith666 jerith666 changed the base branch from master to haskell-updates March 10, 2020 03:08
@jerith666
Copy link
Contributor Author

Done, sorry!

@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskellPackages.persistent-mysql

@cdepillabout cdepillabout merged commit 4a8a6e5 into NixOS:haskell-updates Mar 10, 2020
@cdepillabout
Copy link
Member

Looks good. Thanks for fixing this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jerith666 @cdepillabout