Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sit: mark as broken #82018

Merged
merged 1 commit into from Mar 9, 2020
Merged

sit: mark as broken #82018

merged 1 commit into from Mar 9, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 7, 2020 •
edited

Dependencies in the Cargo.lock fail to build due to mutable self borrows.

Note that we can still compute the newer cargoSha256 for #79975, because both builds fail
in the same way.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
sit: mark as broken
a2514c2 
Dependencies in the Cargo.lock fail to build due to mutable self borrows.
@ofborg ofborg bot requested review from yrashk and dywedir March 7, 2020 20:46
@marsam marsam merged commit 306d507 into NixOS:master Mar 9, 2020
bhipple added a commit to bhipple/nixpkgs that referenced this pull request Mar 9, 2020
@bhipple
[20.03] sit: mark as broken
a81880d 
Dependencies in the Cargo.lock fail to build due to mutable self borrows.

Backport of NixOS#82018

ZHF: NixOS#80379

(cherry picked from commit a2514c2)
@bhipple bhipple mentioned this pull request Mar 9, 2020
Merged
@bhipple bhipple deleted the broken/sit branch March 28, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrashk yrashk Awaiting requested review from yrashk

@dywedir dywedir Awaiting requested review from dywedir

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @marsam