Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ion: mark as broken #82016

Merged
merged 1 commit into from Mar 9, 2020
Merged

ion: mark as broken #82016

merged 1 commit into from Mar 9, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 7, 2020

As noted in the comment, its Rust vendor directory no longer compiles. That
said, we can still compute the new cargoSha256 for #79975, and the package fails in
precisely the same way.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
ion: mark as broken
d5d648b 
As noted in the comment, its Rust vendor directory no longer compiles. That
said, we can still compute the new `cargoSha256`, and the package fails in
precisely the same way.
@ofborg ofborg bot requested a review from dywedir March 7, 2020 20:27
@marsam marsam merged commit e71ea89 into NixOS:master Mar 9, 2020
bhipple added a commit to bhipple/nixpkgs that referenced this pull request Mar 9, 2020
@bhipple
[20.03] ion: mark as broken
dde4748 
Backport of NixOS#82016

ZHF: NixOS#80379

(cherry picked from commit d5d648b)
@bhipple bhipple mentioned this pull request Mar 9, 2020
Merged
@bhipple bhipple deleted the broken/ion branch March 28, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dywedir dywedir Awaiting requested review from dywedir

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @marsam