Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

licensor: fix build and upgrade cargo fetcher #82019

Closed
wants to merge 1 commit into from
Closed

licensor: fix build and upgrade cargo fetcher #82019

wants to merge 1 commit into from

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 7, 2020

The build is currently failing on master in Hydra due to 1 bad integration test;
disabled, and upgraded the fetcher along the way for #79975.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
licensor: fix build and upgrade cargo fetcher
206b538 
The build is currently failing on master in Hydra due to 1 bad integration test;
disabled, and upgraded the fetcher along the way.
@ofborg ofborg bot requested a review from Br1ght0ne March 7, 2020 21:00
@bhipple
Copy link
Contributor Author

bhipple commented Mar 9, 2020

Actually, someone else has opened a PR that actually fixes the test! I'll re-open this after that one is merged and backported.

@bhipple bhipple closed this Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bhipple