Paperwork update #81969
Closed
Paperwork update #81969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also install paperwork-shell and desktop file
It is only used for paperwork and is now unmaintained.
|
@symphorien: Currently on the road, will review tomorrow. Thanks for the pull request. |
aszlig
reviewed
Mar 9, 2020
Comment on lines
+61
to
+65
| # paperwork-shell install copies everything to $HOME/.local/share instead of $out/share | ||
| mkdir -p home/.local | ||
| mkdir -p $out/share | ||
| ln -s $out/share home/.local/share | ||
| HOME=$(readlink -f home) $out/bin/paperwork-shell install |
There was a problem hiding this comment.
What about the following instead?
Suggested change
| # paperwork-shell install copies everything to $HOME/.local/share instead of $out/share | |
| mkdir -p home/.local | |
| mkdir -p $out/share | |
| ln -s $out/share home/.local/share | |
| HOME=$(readlink -f home) $out/bin/paperwork-shell install | |
| XDG_DATA_HOME="$out/share" "$out/bin/payperwork-shell" install |
Also, did you check whether payperwork-shell actually works at runtime?
There was a problem hiding this comment.
yes your suggestion works :)
(minus the typo)
about paperwork-shell: yes, for example result/bin/paperwork-shell chkdeps paperwork works whereas it used to complain about a missing paperwork module.
|
And now that I once again failed at git, I have to close this pull request and reopen a new one. Sorry for the inconvenience. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #81921, which I closed involuntarily.