Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: Update the VA-API patch (fix #81909) #81975

Merged
merged 1 commit into from Mar 10, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Mar 7, 2020

Motivation for this change

Simply updating the patch should be enough to fix the VA-API build again (my build progress is currently at 28717/37651). It does successfully build now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
Copy link
Member Author

primeos commented Mar 10, 2020

It worked on my test setup (Video Decode: Enabled and MojoVideoDecoder).

Update: I've also backported the fix to 19.09 and 20.03.

@primeos primeos merged commit c3267ac into NixOS:master Mar 10, 2020
@poscat0x04
Copy link
Contributor

Is it possible to provide binary cache for chromium with vaapi enabled? It takes quite a while to compile.

@primeos
Copy link
Member Author

primeos commented Mar 12, 2020

@poscat0x04 I also though about this but didn't got around to create an issue.

However, I did quickly draft #82443 just now - thanks for the request :) Let's see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chromium failed to build with vaapi enabled
2 participants