Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-codereview: init at 2020-01-15 #81966

Merged
merged 1 commit into from Mar 9, 2020
Merged

git-codereview: init at 2020-01-15 #81966

merged 1 commit into from Mar 9, 2020

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Mar 7, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ehmry March 7, 2020 10:35
@doronbehar
Copy link
Contributor

@edef1c Please use the complete pull request review template - https://github.com/NixOS/nixpkgs/blob/master/.github/PULL_REQUEST_TEMPLATE.md .

doronbehar
doronbehar reviewed Mar 8, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that LGTM.

pkgs/applications/version-management/git-and-tools/git-codereview/default.nix Show resolved Hide resolved
@marsam marsam merged commit 77c58e6 into NixOS:master Mar 9, 2020
@marsam
Copy link
Contributor

marsam commented Mar 9, 2020

Thanks!

@edef1c edef1c deleted the git-codereview branch March 18, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@doronbehar doronbehar doronbehar left review comments

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edef1c @doronbehar @marsam