Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash: 2.1.0-1 -> 2.1.1-1; libzrustzcash: 2018-10-27 -> 0.1.0 #81994

Merged
merged 2 commits into from Mar 18, 2020
Merged

zcash: 2.1.0-1 -> 2.1.1-1; libzrustzcash: 2018-10-27 -> 0.1.0 #81994

merged 2 commits into from Mar 18, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 7, 2020

Upgrades librustzcash to its first stable release as part of
#79975 cleanups, and also updates zcash
itself to the latest release.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
librustzcash: 2018-10-27 -> 0.1.0
176d90e 
Also includes updates for:

- NixOS#79975
- NixOS/rfcs#45
@bhipple
zcash: 2.1.0-1 -> 2.1.1-1
bd1b24b 
Also enabled parallel building, because otherwise this takes 45+ minutes to
compile! With it enabled, it can build in a couple minutes.
@bhipple
Copy link
Contributor Author

bhipple commented Mar 7, 2020

@GrahamcOfBorg build zcash

@ofborg ofborg bot requested review from rht and tkerber March 7, 2020 17:37
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/116

@bhipple bhipple mentioned this pull request Mar 17, 2020
Closed
@nh2 nh2 merged commit 2fb0068 into NixOS:master Mar 18, 2020
@bhipple bhipple deleted the u/librustzcash branch June 2, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkerber tkerber tkerber approved these changes

@rht rht Awaiting requested review from rht

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bhipple @nixos-discourse @tkerber @nh2