Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.git-trim: init at 0.2.3 #81992

Merged
merged 1 commit into from Mar 11, 2020
Merged

gitAndTools.git-trim: init at 0.2.3 #81992

merged 1 commit into from Mar 11, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 7, 2020

Motivation for this change

Add https://github.com/foriequal0/git-trim

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

doronbehar
doronbehar approved these changes Mar 8, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an awesome package! Tested to work on Linux, though there seems like an upstream bug: see foriequal0/git-trim#55 . I'll approve the package in the meantime as it all LGTM, but if upstream fixes that issue, it'd be nice to fetchpatch a fix for it while this PR is still open :).

@marsam
Copy link
Contributor Author

marsam commented Mar 10, 2020

Thanks for reviewing, I've updated it to 0.2.4 which hopefully fixes the issue you mentioned

@marsam marsam merged commit 6d5fdda into NixOS:master Mar 11, 2020
@marsam marsam deleted the init-git-trim branch March 11, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @doronbehar