Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phodav: 2.3 -> 2.4 #82040

Merged
merged 1 commit into from Mar 15, 2020
Merged

phodav: 2.3 -> 2.4 #82040

merged 1 commit into from Mar 15, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 8, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Valodim
Valodim reviewed Mar 8, 2020
View reviewed changes
Copy link
Contributor

@Valodim Valodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be interested in the outputs consideration. otherwise, lgtm 👍

pkgs/tools/networking/phodav/default.nix Show resolved Hide resolved
@Mic92
Copy link
Member

Mic92 commented Mar 14, 2020

@GrahamcOfBorg build phodav

@Mic92 Mic92 merged commit f1b69e4 into NixOS:master Mar 15, 2020
@ghost ghost deleted the phodav branch March 15, 2020 18:31
@ghost
Copy link
Author

ghost commented Mar 15, 2020

@Mic92 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @Valodim