Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZHF] fix nixos.tests.buildbot #82062

Merged
merged 2 commits into from Mar 8, 2020
Merged

[ZHF] fix nixos.tests.buildbot #82062

merged 2 commits into from Mar 8, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 8, 2020

Motivation for this change

Backport buildbot version bump and test fix for #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

r-ryantm and others added 2 commits March 8, 2020 13:03
@veprbl
Copy link
Member Author

veprbl commented Mar 8, 2020

@GrahamcOfBorg test buildbot

@veprbl veprbl added this to the 20.03 milestone Mar 8, 2020
@ofborg ofborg bot requested a review from lopsided98 March 8, 2020 17:17
@veprbl veprbl merged commit 645522a into NixOS:release-20.03 Mar 8, 2020
@veprbl veprbl deleted the pr/buildbot_backport branch March 8, 2020 21:43
@veprbl veprbl restored the pr/buildbot_backport branch December 1, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@lopsided98 lopsided98 Awaiting requested review from lopsided98

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @r-ryantm @lopsided98