Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.git-dit: mark as broken #81984

Merged
merged 1 commit into from Mar 12, 2020
Merged

gitAndTools.git-dit: mark as broken #81984

merged 1 commit into from Mar 12, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 7, 2020

See inline comment; this does not build on Hydra and either requires custom
patching or a new release from upstream before it will build.

Note that we can still recompute the cargoSha256 for #79975; the package
is broken in the identical way.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
gitAndTools.git-dit: mark as broken
f908cf4 
See inline comment; this does not build on Hydra and either requires custom
patching or a new release from upstream before it will build.

Note that we can still recompute the `cargoSha256` for NixOS#79975; the package
is broken in the identical way.
@bhipple
Copy link
Contributor Author

bhipple commented Mar 7, 2020

CC @Profpatsch @matthiasbeyer

@ofborg ofborg bot requested a review from Profpatsch March 7, 2020 16:00
@Profpatsch
Copy link
Member

I’d love to have this working, but I don’t have the capacity right now.

@Profpatsch Profpatsch merged commit 68a64b2 into NixOS:master Mar 12, 2020
@bhipple bhipple mentioned this pull request Mar 12, 2020
Merged
@matthiasbeyer
Copy link
Contributor

You can package this, or wait until it is merged. This builds for me with rustc 1.40.0... so I suppose this could be packaged: neithernut/git-dit#190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Profpatsch approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @Profpatsch @matthiasbeyer