linuxPackages.rtl88x2bu: init at 2020-03-05 #82032

Ralith · 2020-03-08T03:07:19Z

Motivation for this change

This got my TP-Link Archer T3U working on 19.09. Also seems to build fine with newer kernels. Not sure how we'll know if/when upstream gets support, or whether that's even a possibility.

Things done

doronbehar

Passes nix-build -A linuxPackages_latest.rtl88x2bu and diff LGTM.

contrun · 2020-06-01T16:06:57Z

I just had the same driver missing. Thanks for your PR. Can you please update the rev and sha256. Upstream got updated while this is still waiting for merging. We really need some way to make review for PR faster.

Ralith · 2020-06-01T19:46:21Z

Out of curiosity, are there recent changes to the source repo that affect you? I reviewed it not long ago and didn't see any major updates.

contrun · 2020-06-02T00:29:36Z

As a matter of fact, I haven't tried this driver yet.

contrun · 2020-06-03T00:50:49Z

I just tried this PR. rtl88x2bu driver does not build for kernel 5.6.16.

I tried

{
    "owner": "cilynx",
    "repo": "rtl88x2bu",
    "rev": "0f159d7cd937a12b818121cb1f1c4910bd1adc72",
    "sha256": "0flqnvzfdb4wsiiqv9vf5gfwd5fgpjvhs9zhqknnv1cmp8msgw6y"
}

It works. My wireless nic is now working. Thanks for your contribution.

pkgs/os-specific/linux/rtl88x2bu/default.nix

Ralith · 2020-06-03T01:06:53Z

Updated and confirmed working on latest 20.03.

pkgs/os-specific/linux/rtl88x2bu/default.nix

jonringer

otherwise LGTM

https://github.com/NixOS/nixpkgs/pull/82032
2 packages marked as broken and skipped:
linuxPackages_hardkernel_4_14.rtl88x2bu linuxPackages_hardkernel_latest.rtl88x2bu

15 packages built:
linuxPackages-libre.rtl88x2bu linuxPackages.rtl88x2bu linuxPackages_4_14.rtl88x2bu linuxPackages_4_19.rtl88x2bu linuxPackages_4_4.rtl88x2bu linuxPackages_4_9.rtl88x2bu linuxPackages_5_6.rtl88x2bu linuxPackages_hardened.rtl88x2bu linuxPackages_latest-libre.rtl88x2bu linuxPackages_latest_hardened.rtl88x2bu linuxPackages_latest_xen_dom0.rtl88x2bu linuxPackages_latest_xen_dom0_hardened.rtl88x2bu linuxPackages_testing_bcachefs.rtl88x2bu linuxPackages_xen_dom0.rtl88x2bu linuxPackages_xen_dom0_hardened.rtl88x2bu

pkgs/os-specific/linux/rtl88x2bu/default.nix

jonringer

diff LGTM
commits LGTM
upstream LGTM

https://github.com/NixOS/nixpkgs/pull/82032
2 packages marked as broken and skipped:
linuxPackages_hardkernel_4_14.rtl88x2bu linuxPackages_hardkernel_latest.rtl88x2bu

15 packages built:
linuxPackages-libre.rtl88x2bu linuxPackages.rtl88x2bu linuxPackages_4_14.rtl88x2bu linuxPackages_4_19.rtl88x2bu linuxPackages_4_4.rtl88x2bu linuxPackages_4_9.rtl88x2bu linuxPackages_5_6.rtl88x2bu linuxPackages_hardened.rtl88x2bu linuxPackages_latest-libre.rtl88x2bu linuxPackages_latest_hardened.rtl88x2bu linuxPackages_latest_xen_dom0.rtl88x2bu linuxPackages_latest_xen_dom0_hardened.rtl88x2bu linuxPackages_testing_bcachefs.rtl88x2bu linuxPackages_xen_dom0.rtl88x2bu linuxPackages_xen_dom0_hardened.rtl88x2bu

nixos-discourse · 2020-07-05T18:36:31Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/help-installing-wifi-drivers/4575/7

dav1dnix · 2020-08-17T11:26:13Z

Hi, I am a new user of NixOS, I can't seem to get this working with my wifi adapter which is an Archer T4U V3.
I have tried boot.extraModulePackages = with config.boot.kernelPackages; [ rtl88x2bu ]; and I got the error undefined variable 'rtl88x2bu', I am not sure whether I am doing anything wrong. I tried enabling nixos-unstable channel and putting unstable rtl88x2bu, but that hasn't worked either. The only thing that did work for me was nix-env -i rtl88x2bu. The driver installed, but I still can't connect to my wifi.
Here is my ifconfig and wpa_supplicant

ifconfig
eno1: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet 10.42.0.86  netmask 255.255.255.0  broadcast 10.42.0.255
        inet6 fe80::5ef9:ddff:fe70:c674  prefixlen 64  scopeid 0x20<link>
        ether 5c:f9:dd:70:c6:74  txqueuelen 1000  (Ethernet)
        RX packets 5523  bytes 4434095 (4.2 MiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 4509  bytes 612492 (598.1 KiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0
        device interrupt 20  memory 0xf7c00000-f7c20000  

lo: flags=73<UP,LOOPBACK,RUNNING>  mtu 65536
        inet 127.0.0.1  netmask 255.0.0.0
        inet6 ::1  prefixlen 128  scopeid 0x10<host>
        loop  txqueuelen 1000  (Local Loopback)
        RX packets 2704  bytes 241056 (235.4 KiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 2704  bytes 241056 (235.4 KiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

wpa_supplicant service
● wpa_supplicant.service - WPA Supplicant
   Loaded: loaded (/nix/store/b98pwgf69iwlgr2131sy9bp3sgq69g1h-unit-wpa_supplicant.service/wpa_supplicant.service; enabled; vendor preset: enabled)
   Active: failed (Result: exit-code) since Mon 2020-08-17 12:08:26 BST; 17min ago
  Process: 715 ExecStart=/nix/store/fl0z9il4s3q557pnchnn18xfyf43x1cd-unit-script-wpa_supplicant-start (code=exited, status=255/EXCEPTION)
 Main PID: 715 (code=exited, status=255/EXCEPTION)
       IP: 0B in, 0B out
      CPU: 7ms

Aug 17 12:08:26 nixos fl0z9il4s3q557pnchnn18xfyf43x1cd-unit-script-wpa_supplicant-start[715]:   -q = decrease debugging verbosity (-qq even less)
Aug 17 12:08:26 nixos fl0z9il4s3q557pnchnn18xfyf43x1cd-unit-script-wpa_supplicant-start[715]:   -s = log output to syslog instead of stdout
Aug 17 12:08:26 nixos fl0z9il4s3q557pnchnn18xfyf43x1cd-unit-script-wpa_supplicant-start[715]:   -t = include timestamp in debug messages
Aug 17 12:08:26 nixos fl0z9il4s3q557pnchnn18xfyf43x1cd-unit-script-wpa_supplicant-start[715]:   -u = enable DBus control interface
Aug 17 12:08:26 nixos fl0z9il4s3q557pnchnn18xfyf43x1cd-unit-script-wpa_supplicant-start[715]:   -v = show version
Aug 17 12:08:26 nixos fl0z9il4s3q557pnchnn18xfyf43x1cd-unit-script-wpa_supplicant-start[715]:   -W = wait for a control interface monitor before starting
Aug 17 12:08:26 nixos fl0z9il4s3q557pnchnn18xfyf43x1cd-unit-script-wpa_supplicant-start[715]: example:
Aug 17 12:08:26 nixos fl0z9il4s3q557pnchnn18xfyf43x1cd-unit-script-wpa_supplicant-start[715]:   wpa_supplicant -Dnl80211 -iwlan0 -c/etc/wpa_supplicant.conf
Aug 17 12:08:26 nixos systemd[1]: wpa_supplicant.service: Main process exited, code=exited, status=255/EXCEPTION
Aug 17 12:08:26 nixos systemd[1]: wpa_supplicant.service: Failed with result 'exit-code'.

doronbehar · 2020-08-17T12:54:02Z

nix-env -i rtl88x2bu won't work, as that influences nothing over the system.

boot.extraModulePackages = with config.boot.kernelPackages; [ rtl88x2bu ]; Should work, but perhaps could you give us more context @Dps910? Also, to make sure your channels are updated, could you tell us if this command (run by root) works?

# nix search -u rtl88x2bu

dav1dnix · 2020-08-17T13:06:41Z

nix-env -i rtl88x2bu won't work, as that influences nothing over the system.

boot.extraModulePackages = with config.boot.kernelPackages; [ rtl88x2bu ]; Should work, but perhaps could you give us more context @Dps910? Also, to make sure your channels are updated, could you tell us if this command (run by root) works?
# nix search -u rtl88x2bu

I updated my channels with nix-channel --update and then I did sudo nix search -u rtl88x2bu. It showed me a lot of packages

  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_4_14.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_4_19.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_4_4.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_4_9.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_5_4.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_5_7.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_hardened.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_hardkernel_4_14.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_hardkernel_latest.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_latest-libre.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_latest.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_latest_hardened.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_latest_xen_dom0.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_latest_xen_dom0_hardened.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_testing_bcachefs.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_xen_dom0.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_xen_dom0_hardened.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

doronbehar · 2020-08-17T13:08:45Z

My setup is a little different, and I'm a bit unsure this tests the issue. Could you run exactly this:

sudo su -l
nix-channel --update
nix-channel --list
nix search -u rtl88x2bu

dav1dnix · 2020-08-17T13:17:39Z

My setup is a little different, and I'm a bit unsure this tests the issue. Could you run exactly this:
sudo su -l
nix-channel --update
nix-channel --list
nix search -u rtl88x2bu

[david@nixos:~]$ sudo su -l
[sudo] password for david: 

[root@nixos:~]# nix-channel --update
unpacking channels...

[root@nixos:~]# nix-channel --list
nixos https://nixos.org/channels/nixos-20.03
nixos-unstable https://nixos.org/channels/nixos-unstable

[root@nixos:~]# nix search -u rtl88x2bu 
* nixos-unstable.linuxPackages-libre.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_4_14.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_4_19.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_4_4.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_4_9.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_5_4.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_5_7.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_hardened.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_hardkernel_4_14.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_hardkernel_latest.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_latest-libre.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_latest.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_latest_hardened.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_latest_xen_dom0.rtl88x2bu (rtl88x2bu)
  Realtek rtl88x2bu driver

* nixos-unstable.linuxPackages_latest_xen_dom0_hardened.rtl88x2bu (rtl88x2bu)

doronbehar · 2020-08-17T15:03:52Z

The unstable channel is not actually used. Run as root:

# nix-channel --remove nixos
# nix-channel --remove nixos-unstable
# nix-channel --add https://nixos.org/channels/nixos-unstable nixos

dav1dnix · 2020-08-17T15:46:48Z

The unstable channel is not actually used. Run as root:

# nix-channel --remove nixos
# nix-channel --remove nixos-unstable
# nix-channel --add https://nixos.org/channels/nixos-unstable nixos

That has worked! Thanks :D

ofborg bot added the 8.has: package (new) label Mar 8, 2020

ofborg bot requested a review from hhm0 March 8, 2020 03:17

ofborg bot added 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 labels Mar 8, 2020

doronbehar approved these changes May 23, 2020

View reviewed changes

Ralith force-pushed the rtl88x2bu branch 2 times, most recently from 679be93 to 17a4b3c Compare May 23, 2020 22:46

ofborg bot added the 11.by: package-maintainer label May 23, 2020

contrun reviewed Jun 3, 2020

View reviewed changes

pkgs/os-specific/linux/rtl88x2bu/default.nix Outdated Show resolved Hide resolved

Ralith force-pushed the rtl88x2bu branch from 17a4b3c to 4617127 Compare June 3, 2020 01:06

jonringer reviewed Jun 3, 2020

View reviewed changes

pkgs/os-specific/linux/rtl88x2bu/default.nix Show resolved Hide resolved

pkgs/os-specific/linux/rtl88x2bu/default.nix Outdated Show resolved Hide resolved

Ralith force-pushed the rtl88x2bu branch from 4617127 to ec02a8e Compare June 3, 2020 05:20

jonringer reviewed Jun 3, 2020

View reviewed changes

pkgs/os-specific/linux/rtl88x2bu/default.nix Outdated Show resolved Hide resolved

linuxPackages.rtl88x2bu: init at 2020-05-19

2252fc8

Ralith force-pushed the rtl88x2bu branch from ec02a8e to 2252fc8 Compare June 3, 2020 20:05

jonringer approved these changes Jun 4, 2020

View reviewed changes

jonringer merged commit 38f5fce into NixOS:master Jun 4, 2020

Ralith deleted the rtl88x2bu branch June 4, 2020 20:13

IvarWithoutBones mentioned this pull request Jun 11, 2020

package request: RTL8812BU wireless driver #70408

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

linuxPackages.rtl88x2bu: init at 2020-03-05 #82032

linuxPackages.rtl88x2bu: init at 2020-03-05 #82032

Ralith commented Mar 8, 2020

doronbehar left a comment

contrun commented Jun 1, 2020

Ralith commented Jun 1, 2020

contrun commented Jun 2, 2020

contrun commented Jun 3, 2020

Ralith commented Jun 3, 2020

jonringer left a comment

jonringer left a comment •

edited

nixos-discourse commented Jul 5, 2020

dav1dnix commented Aug 17, 2020 •

edited

doronbehar commented Aug 17, 2020

dav1dnix commented Aug 17, 2020

doronbehar commented Aug 17, 2020

dav1dnix commented Aug 17, 2020

doronbehar commented Aug 17, 2020

dav1dnix commented Aug 17, 2020

linuxPackages.rtl88x2bu: init at 2020-03-05 #82032

linuxPackages.rtl88x2bu: init at 2020-03-05 #82032

Conversation

Ralith commented Mar 8, 2020

Motivation for this change

Things done

doronbehar left a comment

Choose a reason for hiding this comment

contrun commented Jun 1, 2020

Ralith commented Jun 1, 2020

contrun commented Jun 2, 2020

contrun commented Jun 3, 2020

Ralith commented Jun 3, 2020

jonringer left a comment

Choose a reason for hiding this comment

jonringer left a comment • edited

Choose a reason for hiding this comment

nixos-discourse commented Jul 5, 2020

dav1dnix commented Aug 17, 2020 • edited

doronbehar commented Aug 17, 2020

dav1dnix commented Aug 17, 2020

doronbehar commented Aug 17, 2020

dav1dnix commented Aug 17, 2020

doronbehar commented Aug 17, 2020

dav1dnix commented Aug 17, 2020

jonringer left a comment •

edited

dav1dnix commented Aug 17, 2020 •

edited