Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp: 0.6.1 -> 0.6.2 #82021

Merged
merged 1 commit into from Mar 9, 2020
Merged

amp: 0.6.1 -> 0.6.2 #82021

merged 1 commit into from Mar 9, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 7, 2020

The build also happens to be broken on master; this fixes it, along with
upgrading the cargoSha256 for #79975.

Minus the cargo sha changes, this should be backported to 20.03 for

ZHF: #80379

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The build also happens to be broken on master; this fixes it, along with
upgrading the cargoSha256.
@ofborg ofborg bot requested a review from sbourdeauducq March 7, 2020 21:14
@marsam marsam merged commit 255651d into NixOS:master Mar 9, 2020
This was referenced Mar 9, 2020
@bhipple bhipple deleted the u/amp branch June 2, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants