Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeoffice: 973 -> 974 #82038

Merged
merged 1 commit into from Mar 10, 2020
Merged

freeoffice: 973 -> 974 #82038

merged 1 commit into from Mar 10, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Mar 8, 2020

Motivation for this change

Changelog:

https://www.freeoffice.com/en/download/servicepacks

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
Copy link
Contributor

romildo commented Mar 10, 2020

Tested locally. LGTM.

@romildo romildo merged commit 169fc2e into NixOS:master Mar 10, 2020
@romildo romildo mentioned this pull request Apr 3, 2020
Merged
10 tasks
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
@danieldk @stigok
freeoffice: 973 -> 974
5059e31 
Cherry picked from PR NixOS#82038

Changelog:

https://www.freeoffice.com/en/download/servicepacks
(cherry picked from commit 44085e3)
@danieldk danieldk deleted the freeoffice-974 branch July 6, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @romildo