Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eigen: fetch source from gitlab #81998

Merged
merged 1 commit into from
Mar 8, 2020
Merged

eigen: fetch source from gitlab #81998

merged 1 commit into from
Mar 8, 2020
+19 −22

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Mar 7, 2020

@svanderburg @7c6f434c

Motivation for this change

Migrated over to Gitlab.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot requested review from svanderburg and 7c6f434c March 7, 2020 18:04
@eadwu eadwu changed the base branch from master to staging March 7, 2020 18:28
@eadwu eadwu force-pushed the eigen/gitlab-source branch from 9df5356 to ebd4e4b Compare March 7, 2020 18:29
@eadwu
Copy link
Member Author

eadwu commented Mar 7, 2020

There seems to be a lot of rebuilds just from changing the src. I guess this would be better after a new version releases?

@ofborg ofborg bot added 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: vim 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 5001+ and removed 10.rebuild-darwin: 501-1000 10.rebuild-linux: 1001-2500 labels Mar 7, 2020
@eadwu
eigen: fetch source from gitlab

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
805e068
@eadwu eadwu force-pushed the eigen/gitlab-source branch from ebd4e4b to 805e068 Compare March 7, 2020 20:34
@ofborg ofborg bot removed 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: vim 8.has: documentation This PR adds or changes documentation labels Mar 7, 2020
@ofborg ofborg bot removed the 8.has: module (update) This PR changes an existing module in `nixos/` label Mar 7, 2020
veprbl
veprbl approved these changes Mar 7, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff between old unpacked tarball and the new source is minimal

# diff -aru eigen-eigen-b23437e61a07 /nix/store/6kix5k88g20hxhszdxh0kc4jpiz9smvb-source
Only in eigen-eigen-b23437e61a07: .hg_archival.txt
Only in eigen-eigen-b23437e61a07: .hgtags

@markuskowa markuskowa merged commit fd48d9b into NixOS:staging Mar 8, 2020
@eadwu eadwu deleted the eigen/gitlab-source branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa

@veprbl veprbl

@svanderburg svanderburg

@7c6f434c 7c6f434c

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Staging
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @veprbl @markuskowa