torchvision: 0.2.1 -> 0.6.0 #82000

eadwu · 2020-03-07T17:36:12Z

Darwin filenames are kinda not following a pattern.

Motivation for this change

Things done

jonringer · 2020-03-14T22:43:27Z

looks like it's not compatible with master right now:

  ERROR: No matching distribution found for torch==1.4.0 (from torchvision==0.5.0)
cannot build derivation '/nix/store/6hjkr4xfr003j19kzwvirm81zg55h75r-python3.7-pywick-0.5.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/rcsqinlp8q4dh73kj92fa555mx361v08-env.drv': 4 dependencies couldn't be built
[5 built (2 failed), 19 copied (39.4 MiB), 12.1 MiB DL]
error: build of '/nix/store/rcsqinlp8q4dh73kj92fa555mx361v08-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/82000
4 package failed to build:
python37Packages.pywick python37Packages.torchvision python38Packages.pywick python38Packages.torchvision

pytorch is still on 1.2.0

bhipple · 2020-05-09T19:28:22Z

I've fixed up and merged #75827, so this should now be actionable if you're interested in rebasing and giving it another try.

eadwu · 2020-05-09T20:13:28Z

Fixed hashes.

bhipple · 2020-05-09T21:28:23Z

Result of nixpkgs-review pr 82000 1

5 packages marked as broken and skipped:

- linuxPackages_4_9.sysdig
- php73Extensions.zmq
- php74Extensions.pcs
- php74Extensions.zmq
- python37Packages.pyblock

4 packages failed to build:

- python37Packages.pywick
- python37Packages.torchvision
- python38Packages.pywick
- python38Packages.torchvision

eadwu · 2020-05-10T16:02:49Z

Dropped 0.6.0 bump, since it needs torch 1.5.x.

As for the failure, the wheel seems to have a pinned version of 1.4.0, which fails since ours is 1.4.1. As for changing the wheel contents, I'm not sure how to do that.

bhipple · 2020-05-10T16:05:05Z

Ideally it would be nice to just build this from source, instead of using a wheel. Any reason we can't do that?

eadwu · 2020-05-10T16:17:38Z

Not sure, just updated based on existing src.

Tried building the wheel from source instead directly using the wheel and I get error: [Errno 2] No such file or directory: 'which': 'which'.

bhipple · 2020-05-10T16:42:44Z

For that particularly error, try adding which to buildInputs?

eadwu · 2020-05-10T19:55:34Z

Looks like buildInputs isn't used but nativeBuildInputs is used.

Anyway I think I remembered a reason why it should be downloaded from pypi, probably specifically for prebuilt cuda support.

This should build fine now, though I can't guarantee complete feature parity.

bhipple · 2020-05-14T19:23:20Z

Result of nixpkgs-review pr 82000 1

2 packages failed to build:

- python37Packages.pywick
- python38Packages.pywick

2 packages built:

- python37Packages.torchvision
- python38Packages.torchvision

eadwu · 2020-05-15T03:07:09Z

Linked the original build error to pytorch/vision#1827.

Downgrading to 0.5.0 gave a stack trace I couldn't interpret much of, though from what I ripgreped, the calls seem to pass all the necessary parameters.

I'll leave this someone more well-versed with the packaging of torchvision.

Traceback (most recent call last):
  File "nix_run_setup", line 8, in <module>
    exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
  File "setup.py", line 222, in <module>
    'clean': clean,
  File "/nix/store/8ha22qldm2wfhvsz4v9v2h3gmir71rg5-python3.7-setuptools-45.2.0/lib/python3.7/site-packages/setuptools/__init__.py", line 144, in setup
    return distutils.core.setup(**attrs)
  File "/nix/store/2dcsn57cgaxs92ha5swihrab0g3l2h6g-python3-3.7.7/lib/python3.7/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/nix/store/2dcsn57cgaxs92ha5swihrab0g3l2h6g-python3-3.7.7/lib/python3.7/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/nix/store/2dcsn57cgaxs92ha5swihrab0g3l2h6g-python3-3.7.7/lib/python3.7/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/nix/store/8ha22qldm2wfhvsz4v9v2h3gmir71rg5-python3.7-setuptools-45.2.0/lib/python3.7/site-packages/setuptools/command/test.py", line 238, in run
    self.run_tests()
  File "/nix/store/8ha22qldm2wfhvsz4v9v2h3gmir71rg5-python3.7-setuptools-45.2.0/lib/python3.7/site-packages/setuptools/command/test.py", line 260, in run_tests
    exit=False,
  File "/nix/store/2dcsn57cgaxs92ha5swihrab0g3l2h6g-python3-3.7.7/lib/python3.7/unittest/main.py", line 100, in __init__
    self.parseArgs(argv)
  File "/nix/store/2dcsn57cgaxs92ha5swihrab0g3l2h6g-python3-3.7.7/lib/python3.7/unittest/main.py", line 124, in parseArgs
    self._do_discovery(argv[2:])
  File "/nix/store/2dcsn57cgaxs92ha5swihrab0g3l2h6g-python3-3.7.7/lib/python3.7/unittest/main.py", line 244, in _do_discovery
    self.createTests(from_discovery=True, Loader=Loader)
  File "/nix/store/2dcsn57cgaxs92ha5swihrab0g3l2h6g-python3-3.7.7/lib/python3.7/unittest/main.py", line 154, in createTests
    self.test = loader.discover(self.start, self.pattern, self.top)
  File "/nix/store/2dcsn57cgaxs92ha5swihrab0g3l2h6g-python3-3.7.7/lib/python3.7/unittest/loader.py", line 349, in discover
    tests = list(self._find_tests(start_dir, pattern))
  File "/nix/store/2dcsn57cgaxs92ha5swihrab0g3l2h6g-python3-3.7.7/lib/python3.7/unittest/loader.py", line 406, in _find_tests
    full_path, pattern, namespace)
  File "/nix/store/2dcsn57cgaxs92ha5swihrab0g3l2h6g-python3-3.7.7/lib/python3.7/unittest/loader.py", line 483, in _find_test_path
    tests = self.loadTestsFromModule(package, pattern=pattern)
  File "/nix/store/8ha22qldm2wfhvsz4v9v2h3gmir71rg5-python3.7-setuptools-45.2.0/lib/python3.7/site-packages/setuptools/command/test.py", line 55, in loadTestsFromModule
    tests.append(self.loadTestsFromName(submodule))
  File "/nix/store/2dcsn57cgaxs92ha5swihrab0g3l2h6g-python3-3.7.7/lib/python3.7/unittest/loader.py", line 191, in loadTestsFromName
    return self.loadTestsFromModule(obj)
  File "/nix/store/8ha22qldm2wfhvsz4v9v2h3gmir71rg5-python3.7-setuptools-45.2.0/lib/python3.7/site-packages/setuptools/command/test.py", line 55, in loadTestsFromModule
    tests.append(self.loadTestsFromName(submodule))
  File "/nix/store/2dcsn57cgaxs92ha5swihrab0g3l2h6g-python3-3.7.7/lib/python3.7/unittest/loader.py", line 205, in loadTestsFromName
    test = obj()
TypeError: ps_roi_align() missing 3 required positional arguments: 'input', 'boxes', and 'output_size'

akamaus · 2020-12-02T18:56:23Z

@eadwu, probably now is the time to give it a second try ;) I just rebased this PR on top of my nixos-20.09 branch, updated torchvision version to 0.7 (and hash accordingly) and guess what? It works! I guess because pytorch is at 1.6 now. Unfortunately tests fail for some reason, so I just disabled them.

--- a/pkgs/development/python-modules/torchvision/default.nix
+++ b/pkgs/development/python-modules/torchvision/default.nix
@@ -14,15 +14,17 @@
 
 buildPythonPackage rec {
   pname = "torchvision";
-  version = "0.5.0";
+  version = "0.7.0";
 
   src = fetchFromGitHub {
     owner = "pytorch";
     repo = "vision";
     rev = "v${version}";
-    sha256 = "1q4mik66scnqfdvyi46h5py27jk6dx5vkb3g6kz7d0xbcjv9866m";
+    sha256 = "00a5b80b8ca2181sdkm382rldrlzcq3wcns503plbz10ykim2xcf";
   };
 
+  doCheck = false;
+
   # manually check compatibility
   PYTORCH_VERSION = pytorch.version;
   nativeBuildInputs = [ which ]

eadwu · 2020-12-02T19:30:41Z

I'm not going to reopen, it may work for now but there isn't really anyone who going to maintain it anyway judging by the updates.

I just personally pin it on a certain version from pypi with the corresponding pytorch version locally.

eadwu requested review from FRidh and jonringer as code owners March 7, 2020 17:36

ofborg bot added 6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 7, 2020

alyssais added the 2.status: blocked by pr/issue label Mar 14, 2020

eadwu force-pushed the torchvision/0.5.0 branch from e07c461 to d186452 Compare April 7, 2020 18:16

veprbl added the 2.status: merge conflict label May 1, 2020

eadwu changed the title ~~torchvision: 0.2.1 -> 0.5.0~~ torchvision: 0.2.1 -> 0.6.0 May 9, 2020

eadwu force-pushed the torchvision/0.5.0 branch from d186452 to 7654cd8 Compare May 9, 2020 20:10

ofborg bot removed the 2.status: merge conflict label May 9, 2020

eadwu changed the title ~~torchvision: 0.2.1 -> 0.6.0~~ torchvision: 0.2.1 -> 0.5.0 May 10, 2020

eadwu changed the title ~~torchvision: 0.2.1 -> 0.5.0~~ torchvision: 0.2.1 -> 0.6.0 May 10, 2020

eadwu changed the title ~~torchvision: 0.2.1 -> 0.6.0~~ torchvision: 0.2.1 -> 0.5.0 May 10, 2020

eadwu force-pushed the torchvision/0.5.0 branch from 7654cd8 to b784348 Compare May 10, 2020 16:03

bhipple changed the title ~~torchvision: 0.2.1 -> 0.5.0~~ torchvision: 0.2.1 -> 0.6.0 May 14, 2020

eadwu added 2 commits May 14, 2020 22:33

torchvision: 0.2.1 -> 0.5.0

3640f21

torchvision: build from source

74377ee

eadwu force-pushed the torchvision/0.5.0 branch from b9b59d5 to 74377ee Compare May 15, 2020 03:06

eadwu closed this May 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

torchvision: 0.2.1 -> 0.6.0 #82000

torchvision: 0.2.1 -> 0.6.0 #82000

eadwu commented Mar 7, 2020 •

edited

jonringer commented Mar 14, 2020

bhipple commented May 9, 2020

eadwu commented May 9, 2020

bhipple commented May 9, 2020

eadwu commented May 10, 2020

bhipple commented May 10, 2020

eadwu commented May 10, 2020

bhipple commented May 10, 2020

eadwu commented May 10, 2020

bhipple commented May 14, 2020

eadwu commented May 15, 2020 •

edited

akamaus commented Dec 2, 2020

eadwu commented Dec 2, 2020

torchvision: 0.2.1 -> 0.6.0 #82000

torchvision: 0.2.1 -> 0.6.0 #82000

Conversation

eadwu commented Mar 7, 2020 • edited

Motivation for this change

Things done

jonringer commented Mar 14, 2020

bhipple commented May 9, 2020

eadwu commented May 9, 2020

bhipple commented May 9, 2020

eadwu commented May 10, 2020

bhipple commented May 10, 2020

eadwu commented May 10, 2020

bhipple commented May 10, 2020

eadwu commented May 10, 2020

bhipple commented May 14, 2020

eadwu commented May 15, 2020 • edited

akamaus commented Dec 2, 2020

eadwu commented Dec 2, 2020

eadwu commented Mar 7, 2020 •

edited

eadwu commented May 15, 2020 •

edited