Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vivaldi: include libdrm and libgbm #81997

Merged
merged 1 commit into from May 7, 2020
Merged

vivaldi: include libdrm and libgbm #81997

merged 1 commit into from May 7, 2020

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Mar 7, 2020

Motivation for this change

Needed for latest snapshot, we'll see if it's needed for the next stable though.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from NeQuissimus and otwieracz March 7, 2020 17:51
@eadwu
Copy link
Member Author

eadwu commented Mar 7, 2020

Nope, it only affects the snapshot version currently so I don't believe it should be backported.

@FrauH0lle
Copy link
Contributor

Nope, it only affects the snapshot version currently so I don't believe it should be backported.

I can confirm, that this PR has become necessary for Vivaldi version 3+ link

@NeQuissimus NeQuissimus merged commit 795564a into NixOS:master May 7, 2020
@eadwu eadwu deleted the vivaldi-snapshot/fix-rpath-libdrm_gbm branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

@otwieracz otwieracz Awaiting requested review from otwieracz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @FrauH0lle @NeQuissimus