Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] signal-desktop: 1.29.6 -> 1.30.0 (backport) #78428

Merged
merged 3 commits into from Jan 24, 2020
Merged

[19.09] signal-desktop: 1.29.6 -> 1.30.0 (backport) #78428

merged 3 commits into from Jan 24, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Jan 24, 2020 •
edited

Motivation for this change

Would be great if someone could test this on 19.09 in case the new abstractions (like autoPatchelfHook behave differently on 19.09). But since both the test and build log seem fine it should most likely not cause any problems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mogorman and others added 3 commits January 24, 2020 19:53
@mogorman @primeos
signal-desktop: add libappindicator-gtk3
1baefff 
(cherry picked from commit 17da09c)
@worldofpeace @primeos
signal-desktop: use autoPatchelfHook, wrap properly (NixOS#77850)
ff8a947 
Most prominently we don't use `phases` because of NixOS#28910.
This is also problematic when using wrapGAppsHook.
In order to use wrapGAppsHook's automatic wrapping
(this was done manually before because there was no fixupPhase)
we need to install signal at lib/Signal instead of just into libexec.
That's because it would try to wrap .so files.

(cherry picked from commit 15e0b23)
@primeos
signal-desktop: 1.29.6 -> 1.30.0
770bc9f 
Changelog: https://github.com/signalapp/Signal-Desktop/releases/tag/v1.30.0
(cherry picked from commit 9cf50fa)
Reason: Avoid an expired (unusable) build in the stable release
(Signal-Desktop builds expire after 90 days).
@primeos
Copy link
Member Author

primeos commented Jan 24, 2020

@GrahamcOfBorg test signal-desktop

@ofborg ofborg bot requested a review from ixmatus January 24, 2020 19:12
@flokli flokli merged commit 17f02b5 into NixOS:release-19.09 Jan 24, 2020
@flokli
Copy link
Contributor

flokli commented Jan 24, 2020

Tested manually on 19.09, works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixmatus ixmatus Awaiting requested review from ixmatus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@primeos @flokli @mogorman @worldofpeace