Skip to content

range-v3: Fix the AArch64 build by disabling the tests #78447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2020
Merged

range-v3: Fix the AArch64 build by disabling the tests #78447

merged 1 commit into from
Jan 25, 2020
+5 −1

Conversation

primeos
Copy link
Member

@primeos primeos commented Jan 24, 2020

See #75210 (review)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@primeos primeos mentioned this pull request Jan 24, 2020
Merged
10 tasks
@primeos primeos self-assigned this Jan 24, 2020
@jonringer
Copy link
Contributor

@GrahamcOfBorg build range-v3

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 24, 2020
@primeos
Copy link
Member Author

primeos commented Jan 24, 2020

Note: Don't merge this yet - this is only an experimental attempt. If someone has an AArch64 setup feel free to take this PR over ;)

@ofborg ofborg bot requested a review from d-xo January 25, 2020 00:15
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Jan 25, 2020
@ilya-fedin
Copy link
Contributor

ilya-fedin commented Jan 25, 2020 •
edited
Loading

Looks like doCheck does nothing, try cmakeFlags = optional stdenv.isAarch64 "-DRANGE_V3_TESTS=OFF";
https://github.com/ericniebler/range-v3/blob/master/CMakeLists.txt#L57

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 25, 2020
@ilya-fedin
Copy link
Contributor

ilya-fedin commented Jan 25, 2020 •
edited
Loading 

running tests
check flags: -j64 -l64 SHELL=/nix/store/q4116dsmdsab1wgnzdknlpfmxsx897cn-bash-4.4-p23/bin/bash VERBOSE=y test
make: *** No rule to make target 'test'.  Stop.
builder for '/nix/store/vg4d0qp130mx6gfxj1599vbff58iksyf-range-v3-0.10.0.drv' failed with exit code 2
error: build of '/nix/store/vg4d0qp130mx6gfxj1599vbff58iksyf-range-v3-0.10.0.drv' failed

Okay, doCheck should be disabled too

@primeos @ilya-fedin
range-v3: Fix the AArch64 build by disabling the tests
cb6e997 
Another reference for working AArch64 builds:
https://git.alpinelinux.org/aports/tree/community/range-v3/APKBUILD

Co-Authored-By: Ilya Fedin <fedin-ilja2010@ya.ru>
@primeos primeos changed the title range-v3: Disable on AArch64 due to internal compiler errors range-v3: Fix the AArch64 build by disabling the tests Jan 25, 2020
@primeos
Copy link
Member Author

primeos commented Jan 25, 2020

Cool, builds on AArch64 now :)

@primeos primeos merged commit b070035 into NixOS:master Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-xo d-xo

Assignees

@primeos primeos

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@primeos @jonringer @ilya-fedin