This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/guake-failed-to-load-module-unity-gtk-module/5556/6

Could you please describe the problem this is supposed to fix? The current consensus is that LOCALE_ARCHIVE is supposed to be set impurely by the environment (e. g. NixOS) unless other locales than C.utf-8 is explicitly needed.

I am also not sure what the CHARSET environment variable is supposed to do but passing language code to it feels weird.

Hi @jtojnar ,

First of all, I'm a beginner on Nix ecosystem and I enjoyed trying and installing a lot of python packages on my Ubuntu distribution.

Most of them seem to be translate correctly to my native langue: french.

This is not the case with Guake.

The reason is that the most of them use "gettext" directly who's calling the native distribution locales.

Guake use the lib "locales" and return default values: en_us.UTF-8.

After searching on nixpkgs repo, I found and tried todoman who has the same architecture:

It's possible that the good way is not to patch this package but configure linux distribution to integrate Nix.
If that is the case, it would probably be good to update installation script or complete documentation. (I did not find anything about it)

You absolutelty right for CHARSET: not necessary : I delete it.

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

Result of nixpkgs-review pr 78488 run on x86_64-linux 1

@mothsART can you please resolve the merge conflict?

@SuperSandro2000 : Done

Result of nixpkgs-review pr 78488 run on x86_64-darwin 1

Result of nixpkgs-review pr 78488 run on x86_64-linux 1