Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

date: init at v2.4.1 #78458

Closed
wants to merge 1 commit into from
Closed

date: init at v2.4.1 #78458

wants to merge 1 commit into from

Conversation

colemickens
Copy link
Member

Motivation for this change

Used my newest versions of Waybar. Packaging it now for nixpkgs-wayland users.

Blocked on: HowardHinnant/date#537

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens colemickens mentioned this pull request Jan 25, 2020
Closed
@tomberek
Copy link
Contributor

A bit confusing at first. Name collision with common date command in coreutils. I understand it's a library.

@colemickens
Copy link
Member Author

I don't like it either. It seems that some other places it's being packaged as hhdate or howard-hinnart-date : https://repology.org/project/howard-hinnant-date/versions

@lovesegfault lovesegfault mentioned this pull request Feb 2, 2020
Closed
10 tasks
jtojnar
jtojnar reviewed Feb 2, 2020
View reviewed changes
pkgs/development/libraries/date/default.nix
cmakeFlags = [
"-DBUILD_TZ_LIB=true"
"-DBUILD_SHARED_LIBS=true"
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to enable USE_SYSTEM_TZ_DB.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also run tests after enabling ENABLE_DATE_TESTING.

@Ma27 Ma27 mentioned this pull request Feb 18, 2020
Merged
10 tasks
@Ma27
Copy link
Member

Ma27 commented Feb 18, 2020

Since waybar-0.9.0 currently fails to build[1], I opened #80417 which also adds the date package and added you as co-author for the corresponding commit :)

[1] https://hydra.nixos.org/build/113067187

@Ma27 Ma27 closed this in 9704297 Feb 20, 2020
Ma27 added a commit that referenced this pull request Feb 20, 2020
@Ma27
date: init at 2020-01-24
2fadc21 
Needed for waybar-0.9.1.
Closes #78458

Co-authored-by: Cole Mickens <cole.mickens@gmail.com>
(cherry picked from commit 9704297)
@colemickens colemickens deleted the nixpkgs-date branch December 30, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@colemickens @tomberek @Ma27 @jtojnar