Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minecraft: no GPUCache in current directory #78456

Merged
merged 1 commit into from Jan 25, 2020
Merged

minecraft: no GPUCache in current directory #78456

merged 1 commit into from Jan 25, 2020

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Jan 25, 2020

Motivation for this change

Current minecraft-launcher will create a directory GPUCache in CWD and keep it when exited, which is annoying when run in home or desktop.
So this patch will run cd /tmp before starting it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from ryantm, infinisil and cpages January 25, 2020 09:23
@infinisil
Copy link
Member

Ohh so that's where that directory is coming from! I was wondering about that.

@ryantm
Copy link
Member

ryantm commented Jan 25, 2020

tested on NixOS! looks good.

@ryantm ryantm merged commit ac35673 into NixOS:master Jan 25, 2020
@oxalica oxalica deleted the mc-move-to-tmp branch January 26, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@infinisil infinisil Awaiting requested review from infinisil

@cpages cpages Awaiting requested review from cpages

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxalica @infinisil @ryantm